Review 14.3 Merged

95114[TASK] Add contextual option to editRecord ViewHelper

Tim Bäcker CR +2 V +2 Normal +129 −3 updated 08/07/26, 14:27

Commit message

Extend be:link.editRecord with an optional contextual flag that renders
the contextual edit trigger with classic FormEngine fallback, keeping
the shared URL-building logic in one place. The ViewHelper also loads
the required JavaScript module automatically.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Tim Bäcker uploaded patch set 1 08/05/26, 11:35

  2. core-ci voted on patch set 1 V +1 08/05/26, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105975

  3. Garvin Hicking commented on patch set 1 08/06/26, 06:18

    I tried to test this just by placing that line in a custom fluid module, but nothing happens. I even imported the `<f:asset.module identifier="@typo3/backend/element/contextual-record-edit-trigger.js"/>` specifically. What else would I need to take care of to test this? I'm sure I have tomatoes on the eyes.
  4. Tim Bäcker uploaded patch set 2 V +1 08/07/26, 09:05

  5. Tim Bäcker commented on patch set 2 08/07/26, 09:11

    Reply

    Ooops, my bad. The ViewHelper only rendered the custom element markup, but the click behavior from @typo3/backend/element/contextual-record-edit-trigger.js which is loaded by page module automatically (where I tested it) is not always available in custom modules. I've updated the patch now: when contextual is "true", the ViewHelper now registers that JavaScript module via PageRenderer automatically, so no manual f:asset.module is needed in custom Fluid modules.
  6. core-ci voted on patch set 2 V +1 08/07/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106104

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 08/07/26, 11:50

    Reply

    Thanks! Sorry I commented in the wrong issue here, and great you updated both branches. Works now :-)
  8. Garvin Hicking voted on patch set 2 CR +2 V +2 08/07/26, 14:27

  9. Garvin Hicking merged patch set 3 08/07/26, 14:27