95118[BUGFIX] Avoid global routes as breadcrumb targets
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 2
Files 2
Review log 34
-
Ravi Sachaniya uploaded patch set 1 08/06/26, 05:22
-
core-ci voted on patch set 1 V +1 08/06/26, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105992
-
Benni Mack commented on patch set 1 11/11/26, 09:12
Thanks for the patch! The issue has meanwhile been fixed by #110123 ("[BUGFIX] Fix broken module link in breadcrumb", merged in main and 14.3). RecordBreadcrumbProvider::extractRouteIdentifier() now only reuses the current route if the route's own module option is the module the breadcrumb node is built for. record_edit carries no module, so the breadcrumb falls back to the module identifier. A functional test covers this case (breadcrumbUsesModuleIdentifierWhenCurrentRouteBelongsToNoModule). The patch now conflicts with that change. The new test only fails on main because it builds a route with module => web_layout and the identifier record_edit, which can't happen in a real request. Abandoning, thanks again for digging into this! -
Benni Mack abandoned the change 11/11/26, 09:12
Fixed with issue 110123