Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Stale

95125[FEATURE] Support non-PHP cache backends for the site settings cache

Sven Liebert CR -2 V -1 Normal +76 −10 updated 09/15/26, 09:37

Commit message

Site settings can now be stored in database while the default
behavior to use SimpleFileBackend isn't changed.

This is useful for distribution of TYPO3 e.g. in Kubernetes cluster
without slow persistent volume claims (PVC).

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/95125/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/95125/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Benjamin Franzke -2
    • Josef Glatz +1
    • Thomas Maroschik +1
    • Josua Vogel +1
    • Sven Liebert -1
    • Simon Schaufelberger +1
  • Verified V -1 Blocked
    • Josef Glatz +1
    • Thomas Maroschik +1
    • Josua Vogel +1
    • Sven Liebert -1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1522

  1. Sven Liebert uploaded patch set 1 08/06/26, 16:18

  2. Stefan Bürk commented on patch set 2 08/06/26, 16:21

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 08/06/26, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106003

  4. Sven Liebert uploaded patch set 3 08/06/26, 16:30

  5. core-ci voted on patch set 2 V -1 08/06/26, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106004

  6. core-ci voted on patch set 3 V +1 08/06/26, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106006

  7. Garvin Hicking updated the commit message in patch set 4 V +1 08/06/26, 17:40

  8. core-ci voted on patch set 4 V +1 08/06/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106011

  9. Josua Vogel voted on patch set 4 CR +1 08/06/26, 18:27

  10. Sven Liebert uploaded patch set 5 CR +1 V +1 08/07/26, 14:47

  11. core-ci voted on patch set 5 V -1 08/07/26, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106124

  12. Sven Liebert uploaded patch set 6 V -1 08/07/26, 15:03

  13. core-ci voted on patch set 6 V -1 08/07/26, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106127

  14. Sven Liebert uploaded patch set 7 V -1 08/07/26, 15:14

  15. core-ci voted on patch set 7 V +1 08/07/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106130

  16. Thomas Maroschik voted on patch set 7 CR +1 V +1 08/11/26, 12:49

  17. Josua Vogel voted on patch set 7 CR +1 08/11/26, 12:57

  18. Josua Vogel voted on patch set 7 V +1 08/11/26, 14:28

  19. Simon Schaufelberger voted on patch set 7 CR +1 V +1 08/12/26, 00:29

  20. Josef Glatz voted on patch set 7 CR +1 V +1 08/12/26, 05:57

  21. Sven Liebert commented on patch set 7 CR -1 V -1 08/12/26, 09:08

    Unresolved

    After review from @benni@typo3.org I add possibility to reconfigure site configuration cache also
  22. Benjamin Franzke commented on patch set 7 CR -2 09/15/26, 09:37

    SiteSettingsFactory.php:58 Unresolved

    Hey, thanks for this patch. There is one important detail to consider: This class uses `var_export()` to ensure that `cache->require()` will recreate a `SiteSettings` object (based on the fact that `var_export()` can generate code that directly hydrates objects). Due to the next condition – `if ($settings instanceof SiteSettings)` – the cached value **will always be ignored and becomes a NO-OP** because `cache->get()` will always return array. That means it will always "fall-through" and create settings from scratch. We would need to recreate the `SiteSettings` object from an array. That has the drawback, that we need to hydrate the object manually and loose all the `var_export()` niceness of using `::__set_state()` to hydrate automatically. **So what I'd like to have instead:** Check which caching backend is used and use `require`/`var_export()` if it is a `PhpFrontend` and use `get()` + `SiteSettings` from array if not, in order not to lose the `var_export()` features for those who use code-caches. -2 for now (because of the approach and because I'd really like to take a look on the final solution, not because I want to block the patch entirely)