Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95125[FEATURE] Support non-PHP cache backends for the site settings cache
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/95125/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/95125/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benjamin Franzke -2
- Josef Glatz +1
- Thomas Maroschik +1
- Josua Vogel +1
- Sven Liebert -1
- Simon Schaufelberger +1
-
Verified V -1 Blocked
- Josef Glatz +1
- Thomas Maroschik +1
- Josua Vogel +1
- Sven Liebert -1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Core/Bootstrap.php+2 −0
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php1+8 −5
- typo3/sysext/core/Classes/Site/SiteSettingsService.php+3 −3
- typo3/sysext/core/Configuration/DefaultConfiguration.php+8 −0
- typo3/sysext/core/Configuration/Services.yaml+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110383-SupportNonPhpCacheBackendsForSiteSettingsCache.rstnew+50 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+4 −1
Review log 1522
-
Sven Liebert uploaded patch set 1 08/06/26, 16:18
-
Stefan Bürk commented on patch set 2 08/06/26, 16:21
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 08/06/26, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106003
-
Sven Liebert uploaded patch set 3 08/06/26, 16:30
-
core-ci voted on patch set 2 V -1 08/06/26, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106004
-
core-ci voted on patch set 3 V +1 08/06/26, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106006
-
Garvin Hicking updated the commit message in patch set 4
V +108/06/26, 17:40 -
core-ci voted on patch set 4 V +1 08/06/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106011
-
Josua Vogel voted on patch set 4 CR +1 08/06/26, 18:27
-
Sven Liebert uploaded patch set 5
CR +1V +108/07/26, 14:47 -
core-ci voted on patch set 5 V -1 08/07/26, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106124
-
Sven Liebert uploaded patch set 6
V -108/07/26, 15:03 -
core-ci voted on patch set 6 V -1 08/07/26, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106127
-
Sven Liebert uploaded patch set 7
V -108/07/26, 15:14 -
core-ci voted on patch set 7 V +1 08/07/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106130
-
Thomas Maroschik voted on patch set 7 CR +1 V +1 08/11/26, 12:49
-
Josua Vogel voted on patch set 7 CR +1 08/11/26, 12:57
-
Josua Vogel voted on patch set 7 V +1 08/11/26, 14:28
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 08/12/26, 00:29
-
Josef Glatz voted on patch set 7 CR +1 V +1 08/12/26, 05:57
-
Sven Liebert commented on patch set 7 CR -1 V -1 08/12/26, 09:08
Unresolved
After review from @benni@typo3.org I add possibility to reconfigure site configuration cache also -
Benjamin Franzke commented on patch set 7 CR -2 09/15/26, 09:37
SiteSettingsFactory.php:58UnresolvedHey, thanks for this patch. There is one important detail to consider: This class uses `var_export()` to ensure that `cache->require()` will recreate a `SiteSettings` object (based on the fact that `var_export()` can generate code that directly hydrates objects). Due to the next condition – `if ($settings instanceof SiteSettings)` – the cached value **will always be ignored and becomes a NO-OP** because `cache->get()` will always return array. That means it will always "fall-through" and create settings from scratch. We would need to recreate the `SiteSettings` object from an array. That has the drawback, that we need to hydrate the object manually and loose all the `var_export()` niceness of using `::__set_state()` to hydrate automatically. **So what I'd like to have instead:** Check which caching backend is used and use `require`/`var_export()` if it is a `PhpFrontend` and use `get()` + `SiteSettings` from array if not, in order not to lose the `var_export()` features for those who use code-caches. -2 for now (because of the approach and because I'd really like to take a look on the final solution, not because I want to block the patch entirely)