Review main Merged

95141[TASK] Uniform descriptions of CLI commands and scheduler tasks

Riccardo De Contardi CR +2 V +2 Normal +52 −52 updated 09/30/26, 13:58

Commit message

The writing of several texts of EXT:scheduler tasks are rewritten
to be more consistent.
Criteria followed:
- use third person ("action-oriented")
- avoid filling words "this task...", "if set..." etc.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 40

Show 20 more files

Review log 2229

Show 34 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 08/06/26, 20:28

  2. core-ci voted on patch set 1 V +1 08/06/26, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106047

  3. Lina Wolf commented on patch set 1 08/07/26, 08:42

    I think you mainly changed descriptions of commands. So I would suggest to change the changes description accordingly
  4. Lina Wolf commented on patch set 1 08/07/26, 08:43

    Important-102551-FlexFormSection_TOGGLEControlRemoved.rst:29

    I think, if we are chaning a changelog entry for TYPO3 13, we would also have to backport this?
  1. Lina Wolf commented on patch set 1 08/07/26, 08:44

    I like these improvements and think we should also Backport them to 14.3
  2. Riccardo De Contardi commented on patch set 1 08/07/26, 08:45

    Reply

    you mean the commit title and text? Something like: "[TASK] Uniform writing styles of CLI commands" ?
  3. Riccardo De Contardi commented on patch set 1 08/07/26, 08:46

    Important-102551-FlexFormSection_TOGGLEControlRemoved.rst:29 Reply

    IDK what should be done in this case - I can leave the changelog as it is if you want
  4. Riccardo De Contardi updated the commit message in patch set 2 V +1 08/07/26, 09:07

  5. Riccardo De Contardi commented on patch set 2 08/07/26, 09:07

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 08/07/26, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106106

  7. Riccardo De Contardi uploaded patch set 3 V +1 08/07/26, 14:53

  8. core-ci voted on patch set 3 V +1 08/07/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106125

  9. Garvin Hicking commented on patch set 3 08/08/26, 15:02

    Important-102551-FlexFormSection_TOGGLEControlRemoved.rst:29 Reply

    We don't need to backport the changelog change with this IMO. The changelogs are rendered from "main" online. The new label will show up then, but with that very isolated change I doubt actual v13 users will mind. Hope its ok to resolve.
  10. Sarah McCarthy uploaded patch set 4 V +1 08/10/26, 12:18

  11. core-ci voted on patch set 4 V +1 08/10/26, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106277

  12. Sarah McCarthy commented on patch set 4 CR +1 V +1 08/10/26, 12:33

    Looks good :-)
  13. Garvin Hicking commented on patch set 4 CR -1 08/10/26, 12:38

    composer.json:117

    why this? That makes the scheduler to be required in every TYPO3 instance?
  14. Sarah McCarthy uploaded patch set 5 CR +1 V +1 08/10/26, 18:03

  15. Sarah McCarthy commented on patch set 5 V +1 08/10/26, 18:04

    Removed the scheduler from composer.json
  16. core-ci voted on patch set 5 V +1 08/10/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106302

  17. Garvin Hicking voted on patch set 5 CR +1 V +1 08/10/26, 18:18

  18. Garvin Hicking commented on patch set 5 08/10/26, 18:19

    composer.json:117 Reply

    Done
  19. Benni Mack uploaded patch set 6 CR +1 V +1 09/11/26, 23:14

  20. core-ci voted on patch set 6 V -1 09/11/26, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108366

  21. Benni Mack rebased onto patch set 7 V -1 09/30/26, 13:14

  22. core-ci voted on patch set 7 V +1 09/30/26, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109632

  23. Garvin Hicking voted on patch set 7 CR +1 V +1 09/30/26, 13:54

  24. Benni Mack voted on patch set 7 CR +2 V +2 09/30/26, 13:57

  25. Benni Mack merged patch set 8 09/30/26, 13:58