Review main Merged

95144[TASK] Add contract for FAL resource providers

Matthias Vogel CR +2 V +2 Normal +42 −29 updated 08/11/26, 11:37

Commit message

Fluid must resolve FAL resources from Core objects and domain model
without depending on Extbase. The internal carrier contract therefore
lives in EXT:core, where both Fluid and Extbase can use it.

Extbase File and FileReference implement the contract, letting resource
resolution explicitly unwrap their FAL resources instead of relying on
a matching method name.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Praetorius +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1320

  1. Matthias Vogel uploaded patch set 1 08/06/26, 20:41

  2. core-ci voted on patch set 1 V -1 08/06/26, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106053

  3. Matthias Vogel uploaded patch set 2 V -1 08/06/26, 21:14

  4. Matthias Vogel marked it ready for review 08/06/26, 21:15

  5. core-ci voted on patch set 2 V -1 08/06/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106063

  6. Matthias Vogel uploaded patch set 3 V -1 08/07/26, 08:35

  7. core-ci voted on patch set 3 V -1 08/07/26, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106102

  8. Matthias Vogel uploaded patch set 4 V -1 08/07/26, 09:18

  9. Matthias Vogel rebased onto patch set 5 08/07/26, 09:18

  10. core-ci voted on patch set 5 V +1 08/07/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106109

  11. core-ci voted on patch set 4 V +1 08/07/26, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106108

  12. Simon Praetorius voted on patch set 5 CR +1 V +1 08/10/26, 08:09

  13. Benni Mack commented on patch set 5 CR -1 08/10/26, 08:34

    just a few remarks - I was almost about to get it in: I do miss 2-3 lines of comment in the new interface (= I got that from the commit message, which is enough). That being said: I assume the overall goal is to make Fluid more flexible and less dependent from Extbase. Thus, the interface resides in EXT:core not in EXT:extbase. Correct? If so, just state this in the commit message as well. The Provider is a generic name, so I just try to understand it. You're describing an entity / domain model that wraps a File, so instead of a "...Provider" it's like a "...Carrier" or a "...Wrapper"?
  14. Matthias Vogel uploaded patch set 6 CR +1 V +1 08/10/26, 15:07

  15. core-ci voted on patch set 6 V -1 08/10/26, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106291

  16. Matthias Vogel uploaded patch set 7 V -1 08/11/26, 11:10

  17. core-ci voted on patch set 7 V +1 08/11/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106412

  18. Simon Praetorius voted on patch set 7 CR +1 V +1 08/11/26, 11:26

  19. Benni Mack voted on patch set 7 CR +2 V +2 08/11/26, 11:37

  20. Benni Mack merged patch set 8 08/11/26, 11:37