Review main Merged

95146[BUGFIX] Fix PCRE regex breaking suggest wizard on line breaks

Oliver Heins CR +2 V +2 Easy +29 −1 updated 08/11/26, 00:21

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Oliver Heins uploaded patch set 1 08/06/26, 20:46

  2. core-ci voted on patch set 1 V +1 08/06/26, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106056

  3. Niklas Grieger voted on patch set 1 CR +1 V +1 08/06/26, 21:01

  4. Georg Ringer voted on patch set 1 CR +1 V +1 08/06/26, 21:07

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 08/06/26, 21:09

  6. Andreas Kienast commented on patch set 1 CR 0 V 0 08/06/26, 21:12

    The patch itself looks fine and solves the issue. To me it looks simple enough to backport it to v13 as well. What do you think?
  7. Garvin Hicking commented on patch set 1 CR +1 V +1 08/06/26, 23:25

    Reply

    I think I said that 13.4 might be beyond scope. I'd follow your instinct Andi, would be fine.
  8. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 08/07/26, 15:01

  9. Garvin Hicking commented on patch set 2 CR +1 V +1 08/07/26, 15:01

    Reply

    Done
  10. core-ci voted on patch set 2 V +1 08/07/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106126

  11. Stefan Bürk commented on patch set 2 CR +2 V +2 08/11/26, 00:21

    I take this change now, but to be honest the commit message is not optimal. First, it does not really explain anything, Second, it re-states "fix" in the summary line. Usually we avoid stating "fix xy" over explaining `what has been done` (to fix the issue) and further add the background to the commit itself: * What was the issue ? * The used way (reg-exp modifier) has been choosens because why ? Linking deeper information of it. Not every reviewer, even doing archiology work on the codebase / git history knows this at a later point. The code change seems to be "small", but only a handfull of experienced reg-exp writers knows the difference and background. We should really keep that up, recently one-liner commits following more the nothing-to-say style of convential commits raises up. Background here is, that for us the commit message is the first source of truth and in case forge vanish we have the background in the commit message (counter argument to it is mentioned somehow in the forge issue). Merging that now due to the release. @o.heins@leuchtfeuer.com maybe you can take away something from that explanation for further contributions. However, change works.
  12. Stefan Bürk merged patch set 3 08/11/26, 00:21