95153[BUGFIX] Correctly parse ORDER BY clauses with FIND_IN_SET
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Markus Klein +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Christian Spoo uploaded patch set 1 08/06/26, 21:48
-
core-ci voted on patch set 1 V -1 08/06/26, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106072
-
Christian Spoo uploaded patch set 2
V -108/06/26, 22:02 -
core-ci voted on patch set 2 V +1 08/06/26, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106078
-
Markus Klein commented on patch set 2 CR +1 V +1 08/06/26, 22:27
While I'm not a big fan of such PHP lexing code, I guess it is okay for this case. Sidenote: Maybe a clever regex could work as well? -
Oliver Klee voted on patch set 2 V +1 08/06/26, 22:40
-
Christian Spoo commented on patch set 2 08/06/26, 22:55
Reply
I've thought of that as well. However, the regex I ended up with needed to be quite complex in order to correctly track balanced parentheses with the delimiter only being at the top level. Thus, I am unsure whether it would be wise to impact code legibility here. WDYT? -
Markus Klein commented on patch set 2 08/07/26, 11:31
Reply
Perfect. All good IMO. -
Stefan Bürk voted on patch set 2 CR +2 V +2 08/10/26, 23:54
-
Stefan Bürk merged patch set 3 08/11/26, 00:05