95156[BUGFIX] Add missing dependency to Camino theme
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/95156/3 && git checkout FETCH_HEAD - Cherry-pick onto 14.3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/56/95156/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Lukas Dörr +1
-
Verified V +1 Needs a vote
- Lukas Dörr +1
- core-ci +1 CI
Issues 1
Files 3
Review log 710
-
Dmitry Dulepov uploaded patch set 1 08/06/26, 21:56
-
core-ci voted on patch set 1 V -1 08/06/26, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106076
-
Dmitry Dulepov uploaded patch set 2
V -108/07/26, 11:53 -
core-ci voted on patch set 2 V -1 08/07/26, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106114
-
Dmitry Dulepov uploaded patch set 3
V -108/08/26, 16:07 -
core-ci voted on patch set 3 V +1 08/08/26, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106197
-
Lukas Dörr commented on patch set 3 CR +1 V +1 08/08/26, 17:55
without impexp, Camino sets up "successfully" but imports nothing. Added the composer.json line and Composer refused to remove impexp — !fix works!. Note main has the same gap and this only targets 14.3; didn't run the test changes. -
Garvin Hicking commented on patch set 3 08/08/26, 21:29
Reply
I talked to @ben@bnf.dev about this today. My feeling is that we should not really require cms-impexp. This is a "one-time only" dependency, and not "runtime". Setups would not be able to remove the impexp module with this. An option would be to only composer "suggest" this dependency to allow import. You actually could/can use camino as a theme just fine without the initial import (by creating your own data though), so we shouldn't have this as a hard dependency. The best way would be to move parts of impexp to the core to make the initialisation data work without the extension, but that's a larger rewrite of course. Or we could try to "invent" a fresh raw data import. Ideally though we should modify the setup routine to yield an information like "No data was imported. You can require EXT:impexp before importing, and later remove it (or keep it). You can also create your own data, if you do not need a content initialisation." What do you think? -
Dmitry Dulepov commented on patch set 3 08/08/26, 22:04
Reply
The problem exists only for v14 because for v15 impexp is already in the EXT:core. So we can do a suggest, yes. -
Garvin Hicking commented on patch set 3 10/15/26, 12:58
Reply Unresolved
@dmitry.dulepov@gmail.com Would you like to move this forward?