Review main Merged

95163[TASK] Keep the docheader navigation row sticky

Sebastian Michaelsen CR +2 V +2 Normal +154 −66 updated 08/10/26, 18:50

Commit message

The module docheader consists of a navigation row (content navigation
toggle, breadcrumb, language selector) and the button bar. Only the
button bar was sticky, so the navigation row scrolled out of the
viewport and stayed gone for the rest of the editing session.

Both rows are now wrapped in a sticky container, keeping breadcrumb and
language selector reachable while working in long lists. On very small
viewports the container scrolls up by the height of the navigation row,
which preserves the previous behaviour there.

Both bars wrap, so how much of the docheader stays pinned is a runtime
value rather than a fixed one. A resize observer publishes the measured
heights as CSS custom properties, and the sticky offset as well as
everything pinned below the docheader offsets against those.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 69

  1. Sebastian Michaelsen uploaded patch set 1 08/07/26, 07:00

  2. core-ci voted on patch set 1 V +1 08/07/26, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106099

  3. Sebastian Michaelsen updated the commit message in patch set 2 V +1 08/08/26, 12:19

  4. core-ci voted on patch set 2 V +1 08/08/26, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106178

  5. Benjamin Kott uploaded patch set 3 V +1 08/10/26, 18:19

  6. Benjamin Kott voted on patch set 3 CR +1 V +1 08/10/26, 18:31

  7. core-ci voted on patch set 3 V +1 08/10/26, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106310

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 08/10/26, 18:50

  9. Garvin Hicking merged patch set 4 08/10/26, 18:50