Review main Merged

95164[BUGFIX] Fix issue where editors cannot enable or disable redirects

Marno Schmigotzki CR +2 V +2 Normal +110 −1 updated 10/01/26, 20:29

Commit message

DataHandlerPermissionGuardHook validates a sys_redirect update by
checking the incoming field array's source_host and target against the
current backend user's allowed hosts and targets. When the record list's
enable/disable toggle updates a redirect, DataHandler only submits the
single changed field, so source_host and target are absent from that
array and are treated as empty strings, which never match an allowed
host. Editing the full record works because FormEngine always submits
source_host and target along with it, so only the list view toggle was
affected.

The hook now falls back to the persisted source_host and target of the
existing record when they are missing from the incoming field array,
so partial updates are validated against the redirect's actual values
instead of empty strings, while the permission check still applies to
whichever fields the update actually changes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Juliane Wundermann +1
    • Sebastian Michaelsen +1
    • Elias Häußler +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Ulrich Mathes +1
    • Juliane Wundermann +1
    • Oliver Klee +1
    • Sebastian Michaelsen +1
    • Elias Häußler +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1418

  1. Marno Schmigotzki uploaded patch set 1 08/07/26, 09:32

  2. core-ci voted on patch set 1 V +1 08/07/26, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106110

  3. Marno Schmigotzki uploaded patch set 2 V +1 08/07/26, 12:37

  4. core-ci voted on patch set 2 V -1 08/07/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106115

  5. Marno Schmigotzki uploaded patch set 3 V -1 08/07/26, 12:50

  6. core-ci voted on patch set 3 V +1 08/07/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106116

  7. Simon Schaufelberger updated the commit message in patch set 4 V +1 08/08/26, 06:33

  8. Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/08/26, 06:35

  9. core-ci voted on patch set 4 V +1 08/08/26, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106163

  10. Juliane Wundermann voted on patch set 4 CR +1 V +1 08/08/26, 12:31

  11. Ulrich Mathes voted on patch set 4 V +1 08/19/26, 12:26

  12. Oliver Klee voted on patch set 4 V +1 08/19/26, 13:33

  13. Elias Häußler voted on patch set 4 CR +1 V +1 09/30/26, 09:10

  14. Oli Bartsch commented on patch set 4 09/30/26, 09:14

    We might remove the 13 backport. Does IMO not qualify as important bugfix.
  15. Elias Häußler commented on patch set 4 09/30/26, 11:31

    Reply

    Since this is some kind of followup to https://review.typo3.org/c/Packages/TYPO3.CMS/+/92308 (security-fix), I guess this should be included in 13.4 as well. Otherwise the security fix stays partially broken in 13.4.
  16. Sebastian Michaelsen commented on patch set 4 CR +1 V +1 09/30/26, 11:45

    I verified the bug and the fix - it works well. I'd vote for the backport to v13 too. This did work in v13 and the the bug is a regression from a security fix.
  17. Oli Bartsch commented on patch set 4 CR +2 V +2 10/01/26, 20:29

    Reply

    Acknowledged
  18. Oli Bartsch merged patch set 5 10/01/26, 20:29