95164[BUGFIX] Fix issue where editors cannot enable or disable redirects
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Juliane Wundermann +1
- Sebastian Michaelsen +1
- Elias Häußler +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Ulrich Mathes +1
- Juliane Wundermann +1
- Oliver Klee +1
- Sebastian Michaelsen +1
- Elias Häußler +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/redirects/Classes/Hooks/DataHandlerPermissionGuardHook.php+18 −1
- typo3/sysext/redirects/Tests/Functional/Hooks/Fixtures/be_groups.csvnew+3 −0
- typo3/sysext/redirects/Tests/Functional/Hooks/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Hooks/Fixtures/sys_redirect.csvnew+5 −0
- typo3/sysext/redirects/Tests/Functional/Hooks/DataHandlerPermissionGuardHookTest.phpnew+80 −0
Review log 1418
-
Marno Schmigotzki uploaded patch set 1 08/07/26, 09:32
-
core-ci voted on patch set 1 V +1 08/07/26, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106110
-
Marno Schmigotzki uploaded patch set 2
V +108/07/26, 12:37 -
core-ci voted on patch set 2 V -1 08/07/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106115
-
Marno Schmigotzki uploaded patch set 3
V -108/07/26, 12:50 -
core-ci voted on patch set 3 V +1 08/07/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106116
-
Simon Schaufelberger updated the commit message in patch set 4
V +108/08/26, 06:33 -
Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/08/26, 06:35
-
core-ci voted on patch set 4 V +1 08/08/26, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106163
-
Juliane Wundermann voted on patch set 4 CR +1 V +1 08/08/26, 12:31
-
Ulrich Mathes voted on patch set 4 V +1 08/19/26, 12:26
-
Oliver Klee voted on patch set 4 V +1 08/19/26, 13:33
-
Elias Häußler voted on patch set 4 CR +1 V +1 09/30/26, 09:10
-
Oli Bartsch commented on patch set 4 09/30/26, 09:14
We might remove the 13 backport. Does IMO not qualify as important bugfix. -
Elias Häußler commented on patch set 4 09/30/26, 11:31
Reply
Since this is some kind of followup to https://review.typo3.org/c/Packages/TYPO3.CMS/+/92308 (security-fix), I guess this should be included in 13.4 as well. Otherwise the security fix stays partially broken in 13.4. -
Sebastian Michaelsen commented on patch set 4 CR +1 V +1 09/30/26, 11:45
I verified the bug and the fix - it works well. I'd vote for the backport to v13 too. This did work in v13 and the the bug is a regression from a security fix. -
Oli Bartsch commented on patch set 4 CR +2 V +2 10/01/26, 20:29
Reply
Acknowledged -
Oli Bartsch merged patch set 5 10/01/26, 20:29