Review main Merged

95170[BUGFIX] Fix free mode rendering in comparison view

Marcel Küpper CR +2 V +2 Hard +547 −31 updated 08/10/26, 19:56

Commit message

The layout module binds translations to the default
language (#106649). In free mode that binding is
missing a target and all items get rendered in the
first row. Additionally all items got hidden, when
the default language column had not items.

The language comparison now always shows connected
language items as rows and languages in free mode
independently from the default language binding.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Eric Harrer +1
    • Denis Mir +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Eric Harrer +1
    • Denis Mir +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1518

  1. Marcel Küpper uploaded patch set 1 08/07/26, 19:16

  2. Marcel Küpper updated the commit message in patch set 2 08/07/26, 19:20

  3. core-ci voted on patch set 1 V +1 08/07/26, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106136

  4. core-ci voted on patch set 2 V +1 08/07/26, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106137

  5. Eric Harrer voted on patch set 2 CR +1 V +1 08/07/26, 21:21

  6. Denis Mir commented on patch set 2 V -1 08/08/26, 03:51

    To be honest from a pure user and UX perspective this patch is way to simplified. When having more then 20 CEs on a page you still can't do a real comparison in free mode since the content doesn't fit next to each other. (since each element on sys language 0 gets its own column compared to the one column on sys lang > 0) I've talked to one of our customers (TYPO3 with 30 plus languages and over 20 trees) which really needs and uses the free mode comparison and this would be a no go. So from my perspective this is much worse than what we had in TYPO3 < 14LTS from a pure UX perspective. I understand the technical point but in this case users have to use that comparison and they don't care if something is technically correct.
  7. Marcel Küpper uploaded patch set 3 CR +1 V +1 08/08/26, 11:06

  8. core-ci voted on patch set 3 V +1 08/08/26, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106173

  9. Marcel Küpper commented on patch set 3 08/08/26, 11:14

    Reply

    Discussed this with Eric and we'd another look at it. We agree, that the view could be approved, when there's no connected language rendered to compare against. However, we also have the opinion that if languages in different modes are shown at the same time, it must always be distinguishable, if a content element is related to the default language or not. Therefore I provided a new patch set, which renders all elements in one row, as long as no language in connected mode is rendered.
  10. Garvin Hicking commented on patch set 3 CR +1 V +1 08/08/26, 14:24

    Reply

    I like that current approach - I really think providing a factual hard to establish correlation creates other issues. This IMO improves the current situation and other opportunities to "show implied connections" can still be done with followups or custom integration/DOM adaption. Thanks for having so many discussions about this and trying to figure out a way out of it!
  11. Eric Harrer voted on patch set 3 CR +1 V +1 08/09/26, 11:41

  12. Denis Mir commented on patch set 3 CR +1 V +1 08/09/26, 20:21

    Looks good now.
  13. Denis Mir commented on patch set 3 08/09/26, 20:27

    Reply

    Looks good now.
  14. Garvin Hicking voted on patch set 3 CR +2 V +2 08/10/26, 08:19

  15. Garvin Hicking commented on patch set 3 CR +1 V +1 08/10/26, 08:25

    We'll have to sort out the backport to 14.3 on this due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/93552 not being backported there, if I see this properly
  16. Benni Mack commented on patch set 3 08/10/26, 10:21

    Reply

    AFAIK April 9 was before the LTS = before the branching
  17. Garvin Hicking commented on patch set 3 CR +2 V +2 08/10/26, 19:56

    Reply

    It actually was https://review.typo3.org/c/Packages/TYPO3.CMS/+/94256 that caused the merge conflict. Marcel resolved it! 😊
  18. Garvin Hicking merged patch set 4 08/10/26, 19:56