Review main Merged

95174[TASK] Decouple session cookie emission from user authentication

Benni Mack CR +2 V +2 Normal +66 −24 updated 08/10/26, 13:28

Commit message

Applying the session cookie to a PSR-7 response is now handled by
the new `SetCookieService->applyCookieToResponse()` method, which
receives the user session, the evaluated cookie behavior and the
normalized parameters of the current request. The authentication
middlewares of backend and frontend use this service directly.

`AbstractUserAuthentication->appendCookieToResponse()` is reduced to
an internal shim delegating to the service and no longer falls
back to reading the request from `$GLOBALS['TYPO3_REQUEST']`,
resolving a long-standing todo in the authentication object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Benni Mack uploaded patch set 1 08/08/26, 09:28

  2. Benni Mack updated the commit message in patch set 2 08/08/26, 09:30

  3. core-ci voted on patch set 1 V +1 08/08/26, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106166

  4. core-ci voted on patch set 2 V +1 08/08/26, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106167

  5. Oliver Klee updated the commit message in patch set 3 V +1 08/08/26, 12:25

  6. core-ci voted on patch set 3 V +1 08/08/26, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106179

  7. Georg Ringer voted on patch set 3 CR +1 V +1 08/10/26, 08:00

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 08/10/26, 13:24

  9. Benni Mack voted on patch set 3 CR +2 V +2 08/10/26, 13:28

  10. Benni Mack merged patch set 4 08/10/26, 13:28