Review main Merged

95179[BUGFIX] Let stdWrap override apply the value "0"

Benjamin Kott CR +2 V +2 Easy +38 −2 updated 08/26/26, 23:24

Commit message

The stdWrap property "override" replaced the current content whenever
the configured value was truthy after trimming. In PHP the string "0"
is falsy, so an override evaluating to a single zero silently kept the
previous content instead of replacing it. TypoScript delivers every
value as a string, which made "0" the one scalar an override could not
produce, for example when the value came from a condition or a nested
stdWrap.

The check now compares the trimmed value against an empty string, so
only an unset, empty or whitespace-only value leaves the content
untouched, while "0" overrides like any other value.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Benjamin Kott uploaded patch set 1 08/08/26, 20:02

  2. core-ci voted on patch set 1 V +1 08/08/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106201

  3. Mathias Brodala commented on patch set 1 08/10/26, 06:45

    Can we add an Important RST for this? After all this is a change in behavior, even if a bug was fixed. On that note we should consider not backporting this to v13.
  4. Benjamin Kott commented on patch set 1 CR -1 08/10/26, 07:02

    Reply

    sure! will check it later
  5. Georg Ringer commented on patch set 1 08/10/26, 08:02

    this should be have an important.rst + no 13.4 backport pls
  6. Benjamin Kott uploaded patch set 2 CR -1 V +1 08/24/26, 12:18

  7. Benjamin Kott commented on patch set 2 08/24/26, 12:19

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 08/24/26, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107029

  9. Georg Ringer voted on patch set 2 CR +1 V +1 08/25/26, 17:45

  10. Josua Vogel voted on patch set 2 CR +1 V +1 08/26/26, 14:18

  11. Benjamin Kott voted on patch set 2 CR +2 V +2 08/26/26, 21:58

  12. Benjamin Kott merged patch set 3 08/26/26, 23:24