Review main Merged

95187[BUGFIX] Reject indexes over undeclared columns

Stefan Bürk CR +2 V +2 Hard +255 −0 updated 09/02/26, 09:35

Commit message

A table definition that indexes a column it does not declare is
invalid. MySQL and PostgreSQL refuse such an index themselves, which
keeps the damage to a failed statement.

SQLite accepts it. A quoted identifier that matches no column counts
as a string literal there, so the index is created over a constant
expression and ends up covering no column at all. Introspecting the
database is impossible from that point on, which takes down the
schema analysis of the install tool and of the command line alike,
and leaves no way to bring the database back into shape.

Check the columns of every index against the table once all
definitions for that table are merged. Checking a single statement
would not do: extensions add an index to a table owned by another
extension in a statement of their own, which does not repeat the
columns the index covers.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2433

Show 48 earlier messages
  1. Stefan Bürk uploaded patch set 1 08/09/26, 21:00

  2. core-ci voted on patch set 1 V +1 08/09/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106227

  3. Stefan Bürk rebased onto patch set 2 V +1 08/11/26, 00:32

  4. core-ci voted on patch set 2 V +1 08/11/26, 00:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106351

  5. Stefan Bürk uploaded patch set 3 V +1 08/11/26, 04:00

  6. core-ci voted on patch set 3 V +1 08/11/26, 04:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106365

  7. Stefan Bürk rebased onto patch set 4 V +1 08/11/26, 05:17

  8. core-ci voted on patch set 4 V +1 08/11/26, 05:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106384

  1. Stefan Bürk rebased onto patch set 5 V +1 08/11/26, 11:38

  2. core-ci voted on patch set 5 V +1 08/11/26, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106415

  3. Stefan Bürk uploaded patch set 6 08/11/26, 13:29

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  4. core-ci voted on patch set 6 V +1 08/11/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106431

  5. Stefan Bürk updated the commit message in patch set 7 V +1 08/11/26, 14:14

  6. Stefan Bürk commented on patch set 7 08/11/26, 14:15

    This change is ready for review.
  7. core-ci voted on patch set 7 V +1 08/11/26, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106444

  8. Oliver Klee voted on patch set 7 V +1 08/11/26, 14:33

  9. Stefan Bürk rebased onto patch set 8 V +1 08/14/26, 20:48

  10. core-ci voted on patch set 8 V +1 08/14/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106720

  11. Simon Schaufelberger voted on patch set 8 CR +1 08/15/26, 09:50

  12. Simon Schaufelberger voted on patch set 8 V +1 08/15/26, 12:39

  13. Wouter Wolters voted on patch set 8 CR +1 V +1 08/16/26, 14:09

  14. Markus Klein voted on patch set 8 CR +1 V +1 08/16/26, 15:58

  15. Georg Ringer commented on patch set 8 08/17/26, 06:00

    sholdnt the rst then be in 13.4 directory?
  16. Oliver Klee voted on patch set 8 CR +1 V +1 08/17/26, 07:53

  17. Stefan Bürk commented on patch set 8 CR -1 08/31/26, 07:30

    Reply

    Correct.
  18. Stefan Bürk uploaded patch set 9 CR +1 V +1 08/31/26, 10:28

  19. Stefan Bürk commented on patch set 9 08/31/26, 10:36

    Reply

    Done
  20. core-ci voted on patch set 9 V +1 08/31/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107405

  21. Oliver Klee voted on patch set 9 V +1 08/31/26, 10:41

  22. Simon Schaufelberger voted on patch set 9 CR +1 V +1 08/31/26, 10:43

  23. Benni Mack voted on patch set 9 CR +1 V +1 09/02/26, 04:50

  24. Stefan Bürk voted on patch set 9 CR +2 V +2 09/02/26, 08:56

  25. Stefan Bürk merged patch set 10 09/02/26, 09:35