95206[TASK] Make the contextual record edit sheet resizable
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Florian Keitgen +1
- Garvin Hicking +1
- Matthias Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- Matthias Vogel +1
- core-ci +1 CI
Issues 2
Files 13
- Build/Sources/Sass/component/_modal.scss+42 −0
- Build/Sources/TypeScript/backend/element/contextual-record-edit-trigger.ts2+9 −1
- Build/Sources/TypeScript/backend/modal.ts+124 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −0
- typo3/sysext/backend/Classes/Preview/RecordFieldPreviewProcessor.php+1 −0
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+1 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.fluid.html+1 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.fluid.html+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+7 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/contextual-record-edit-trigger.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+10 −1
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Modal.fluid.html+23 −0
Review log 2123
-
Oli Bartsch uploaded patch set 1 08/10/26, 13:38
-
Oli Bartsch updated the commit message in patch set 2 08/10/26, 13:39
-
Garvin Hicking commented on patch set 2 08/10/26, 14:19
We should also add this to the styleguide as a variant for modalscontextual-record-edit-trigger.ts:31```suggestion * width independently per context. This might be just the database table ``` -
Oli Bartsch uploaded patch set 3 08/10/26, 16:00
-
Oli Bartsch updated the commit message in patch set 4 08/10/26, 16:00
-
Oli Bartsch commented on patch set 4 08/10/26, 16:00
Reply
Donecontextual-record-edit-trigger.ts:31ReplyDone -
Garvin Hicking commented on patch set 4 CR +1 V +1 08/10/26, 16:44
Yeah, this is what would make me feel comfortable :-) -
Matthias Vogel voted on patch set 4 CR +1 V +1 08/11/26, 11:10
-
Oli Bartsch commented on patch set 4 08/11/26, 15:52
We need to wait for feedback of Flix & Laura on this. -
Oli Bartsch rebased onto patch set 5
CR +1V +108/20/26, 08:03 -
Oli Bartsch wrote 08/20/26, 08:04
Unset private -
Oli Bartsch commented on patch set 5 08/20/26, 08:05
Reply
feedback received. Both are fine with adjusting after having this tested in the wild for a couple of months now. -
core-ci voted on patch set 5 V +1 08/20/26, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106911
-
Garvin Hicking voted on patch set 5 CR +1 V +1 08/20/26, 10:04
-
Matthias Vogel voted on patch set 5 CR +1 V +1 08/20/26, 10:06
-
Garvin Hicking updated the commit message in patch set 6
CR +1V +108/20/26, 10:20 -
Garvin Hicking voted on patch set 6 CR +1 V +1 08/20/26, 10:20
-
Matthias Vogel voted on patch set 6 CR +1 V +1 08/20/26, 10:21
-
core-ci voted on patch set 6 V +1 08/20/26, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106912
-
Georg Ringer voted on patch set 6 CR +1 V +1 08/20/26, 13:33
-
Oli Bartsch voted on patch set 6 CR +2 V +2 08/21/26, 18:43
-
Oli Bartsch merged patch set 7 08/21/26, 18:43
-
Florian Keitgen voted on patch set 7 CR +1 08/24/26, 04:58