Review main Merged

95210[BUGFIX] Index external files of storages which are not public

Benni Mack CR +2 V +2 Hard +287 −3 updated 09/02/26, 06:32

Commit message

Indexed Search follows links to files in the rendered page and
indexes their content when config.index_externals is enabled.
This only worked for files of a storage marked as public, as
those are linked with a directly accessible URL.

Files of a storage which is not public are delivered by the file
dump eID script instead, resulting in a link such as
"index.php?eID=dumpFile&t=f&f=17&token=...". Such a link could
not be resolved to a file and was silently skipped, although the
file was readable on the server side.

These URLs are now resolved back to the FAL object they point to,
which is then made available locally for the external file
parsers. Only URLs carrying a valid token are taken into account,
so links to arbitrary files can not expose content of a storage
which is not publicly available.

As the resolved file may live outside the public web path, an
already resolved local path is now used as-is instead of being
validated against the public web path again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Benni Mack uploaded patch set 1 08/10/26, 16:26

  2. core-ci voted on patch set 1 V +1 08/10/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106296

  3. Benni Mack marked it ready for review 08/10/26, 17:03

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/02/26, 05:44

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/02/26, 06:15

  6. Benni Mack voted on patch set 1 CR +2 V +2 09/02/26, 06:32

  7. Benni Mack merged patch set 2 09/02/26, 06:32