Review main Merged

95213[BUGFIX] Create file dump tokens with SHA3-256 everywhere

Benni Mack CR +2 V +2 Normal +186 −2 updated 08/10/26, 20:10

Commit message

Switching the HMAC of the file dump token to SHA3-256 covered
FileDumpController, which validates the token, and
ResourceStorage, which creates it. Two other places creating
such a token were left with the default algorithm and therefore
generate a token the controller rejects with "403 Forbidden":

* the file link ViewHelper, used whenever f:link.file points to
  a file of a storage which is not public
* the form framework, which streams uploaded files of its own
  storage through the file dump script

Both now pass SHA3-256 as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 78

  1. Benni Mack uploaded patch set 1 08/10/26, 17:03

  2. Benni Mack marked it ready for review 08/10/26, 17:03

  3. core-ci voted on patch set 1 V +1 08/10/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106299

  4. Oliver Hader voted on patch set 1 CR +1 V +1 08/10/26, 18:07

  5. Oliver Klee voted on patch set 1 V +1 08/10/26, 19:09

  6. Wouter Wolters voted on patch set 1 CR +1 V +1 08/10/26, 19:53

  7. Benni Mack voted on patch set 1 CR +2 V +2 08/10/26, 20:10

  8. Benni Mack merged patch set 2 08/10/26, 20:10