Review main Merged

95240[BUGFIX] Ignore tables that exist as views

Stefan Bürk CR +2 V +2 Normal +134 −0 updated 08/23/26, 18:12

Commit message

A table name declared in `ext_tables.sql` or through TCA can exist as
a view on the connection it is mapped to, which is a common way to
make data of another system available to TYPO3.

TYPO3 does not own such an object. Altering or dropping it would act
on something the declaration does not describe, and creating it fails
outright, because a view already occupies the name.

Introspect the views of a connection and take them out of both the
current and the expected schema before the two are compared. Removing
them from both sides covers creating, altering, renaming and dropping
in one place, whichever side the name appears on.

This takes views out of the comparison and nothing else. Making what
is compared configurable in general is a separate matter.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 2027

Show 12 earlier messages
  1. Stefan Bürk uploaded patch set 1 08/11/26, 00:32

  2. core-ci voted on patch set 1 V +1 08/11/26, 00:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106360

  1. Stefan Bürk rebased onto patch set 2 V +1 08/11/26, 04:00

  2. core-ci voted on patch set 2 V +1 08/11/26, 04:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106367

  3. Stefan Bürk rebased onto patch set 3 V +1 08/11/26, 05:17

  4. core-ci voted on patch set 3 V +1 08/11/26, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106386

  5. Stefan Bürk rebased onto patch set 4 V +1 08/11/26, 11:38

  6. core-ci voted on patch set 4 V +1 08/11/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106417

  7. Stefan Bürk rebased onto patch set 5 V +1 08/11/26, 13:29

  8. core-ci voted on patch set 5 V +1 08/11/26, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106433

  9. Stefan Bürk updated the commit message in patch set 6 V +1 08/11/26, 14:14

  10. Stefan Bürk commented on patch set 6 08/11/26, 14:15

    This change is ready for review.
  11. Oliver Klee voted on patch set 6 V +1 08/11/26, 14:35

  12. core-ci voted on patch set 6 V +1 08/11/26, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106446

  13. Oliver Klee commented on patch set 6 CR -1 08/12/26, 08:17

    ConnectionMigrator.php:179

    This comment now is in the wrong place - it should stay directly above `buildSchemaDiff`.
  14. Stefan Bürk uploaded patch set 7 CR -1 V +1 08/14/26, 20:48

  15. Stefan Bürk commented on patch set 7 08/14/26, 20:53

    ConnectionMigrator.php:179 Reply

    Done.
  16. core-ci voted on patch set 7 V +1 08/14/26, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106722

  17. Wouter Wolters voted on patch set 7 CR +1 08/14/26, 21:04

  18. Markus Klein commented on patch set 7 CR +1 08/14/26, 21:45

    Thanks for this change!!
  19. Markus Klein voted on patch set 7 V +1 08/14/26, 22:56

  20. Georg Ringer voted on patch set 7 CR +1 V +1 08/15/26, 08:07

  21. Simon Schaufelberger voted on patch set 7 CR +1 V +1 08/15/26, 12:38

  22. Wouter Wolters voted on patch set 7 V +1 08/16/26, 14:10

  23. Oliver Klee voted on patch set 7 CR +1 V +1 08/17/26, 07:55

  24. Georg Ringer voted on patch set 7 CR +2 V +2 08/23/26, 18:12

  25. Georg Ringer merged patch set 8 08/23/26, 18:12