Review 13.4 Merged

95253[SECURITY] Prevent local Fetch/XHR-based request forgery via XSS

Oliver Hader CR +2 V +2 Hard +350 −60 updated 08/11/26, 07:17

Commit message

The core `ReferrerEnforcer` implentation enforces based on request
directory for `TYPE_REFERRER_SAME_ORIGIN` (=same-application)
assertions.

Since #87889 the backend application resides within the document
root, and no longer in `typo3/`, and is served from /index.php,
which means that all requests to that site are incorrectly detected
as `TYPE_REFERRER_SAME_ORIGIN`. The install tool still has its own
entry script `typo3/install.php`, which shares its directory with
the backend entry point - therefore backend requests are incorrectly
detected as same-origin there as well.

The `TYPE_REFERRER_SAME_ORIGIN` detection is therefore adapted to
take the concrete URI details of the respective application
into account.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 7

Review log 34

  1. Oliver Hader uploaded patch set 1 08/11/26, 07:08

  2. Oliver Hader commented on patch set 1 CR +2 V +2 08/11/26, 07:08

    Auto-approved
  3. Oliver Hader merged patch set 2 08/11/26, 07:08

  4. core-ci voted on patch set 1 V +1 08/11/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106399