Review main Merged

95262[BUGFIX] Mark multi checkbox groups as role="group"

Sebastian Mendel CR +2 V +2 Normal +49 −2 updated 08/14/26, 13:39

Commit message

The container wrapping the checkboxes carried role="radiogroup", the
same attribute the radio button partial uses, where it is correct.

radiogroup states that the group owns radios and that exactly one of
them may be selected, so assistive technology announces a set of
checkboxes as a single-choice group. WAI-ARIA requires the owned
elements of a radiogroup to carry role="radio"; the mismatch is
reported as aria-required-children.

The role becomes "group", which is what a set of related checkboxes
is. It is corrected rather than dropped because renderFieldset is
configurable: without the fieldset, this attribute and its aria-label
are the only thing that groups the options.

The test renders a form through FormRuntime, which needs a language on
the request: TranslationService derives the locale from it, so element
labels cannot be resolved without one.

Added tests fixate this behavior.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Sebastian Mendel uploaded patch set 1 08/11/26, 12:19

  2. Sebastian Mendel updated the commit message in patch set 2 08/11/26, 12:25

  3. core-ci voted on patch set 1 V +1 08/11/26, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106425

  4. core-ci voted on patch set 2 V +1 08/11/26, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106426

  5. Josua Vogel voted on patch set 2 CR +1 V +1 08/11/26, 12:40

  6. Sebastian Mendel uploaded patch set 3 CR +1 V +1 08/11/26, 12:49

  7. core-ci voted on patch set 3 V +1 08/11/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106429

  8. Sebastian Mendel wrote 08/11/26, 13:02

    Topic set to form
  9. Georg Ringer voted on patch set 3 CR +1 V +1 08/14/26, 12:55

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 08/14/26, 13:12

  11. Oliver Klee voted on patch set 3 CR +1 08/14/26, 13:24

  12. Stefan Bürk merged patch set 4 08/14/26, 13:39