Review main Merged

95263[TASK] Raise doctrine/dbal to ~4.4.4

Stefan Bürk CR +2 V +2 Normal +57 −5 updated 09/02/26, 12:16

Commit message

doctrine/dbal `4.4.4` adds the platform class
`Doctrine\DBAL\Platforms\MariaDB120300Platform` for MariaDB 12.3 [1].
It does not exist in `4.4.0` up to `4.4.3`, so the previous constraint
`~4.4.3` allowed an installation without it.

doctrine/dbal 4 removed the doctrine event system. TYPO3 no longer
adjusts platform behaviour through listeners but by extending each
platform class and overriding the methods - the column type comment
handling and the TYPO3 specific table option handling both live there.

`CustomPlatformDriverDecorator` maps every doctrine platform onto its
TYPO3 subclass and ends in `default => $platform`. A doctrine platform
without a TYPO3 counterpart therefore does not fail, it falls through
and runs unextended, silently dropping those adjustments. Running
MariaDB 12.3 would hit exactly that.

`TYPO3\CMS\Core\Database\Platform\MariaDB120300Platform` is added
accordingly, adopting the traits and the `getAlterTableSQL()` override
of the other extended MariaDB platform classes, and is registered in
the decorator.

The constraint stays pinned with the tilde operator: `~4.4.4` resolves
to `>=4.4.4 <4.5.0`, keeping doctrine limited to patch level upgrades.
A new minor version can carry platform changes that are incompatible
with the TYPO3 platform adaptions and overrides, and those are reviewed
rather than picked up automatically.

The constraint is declared in four files, not only in the root
`composer.json`: `typo3/sysext/core`, `typo3/sysext/install` and
`typo3/sysext/redirects` require doctrine/dbal on their own.

Composer is invoked through the containerized `runTests.sh` wrapper,
because it exports `COMPOSER_ROOT_VERSION`. Without it the root package
falls back to `1.0.0` and the monorepo requirements of the
sysextension packages cannot be resolved.

Used command(s):

```
Build/Scripts/runTests.sh -s composer -- require \
  -d typo3/sysext/core --no-update --no-install \
  'doctrine/dbal':'~4.4.4'
Build/Scripts/runTests.sh -s composer -- require \
  -d typo3/sysext/install --no-update --no-install \
  'doctrine/dbal':'~4.4.4'
Build/Scripts/runTests.sh -s composer -- require \
  -d typo3/sysext/redirects --no-update --no-install \
  'doctrine/dbal':'~4.4.4'
Build/Scripts/runTests.sh -s composer -- require -w \
  'doctrine/dbal':'~4.4.4'
```

`doctrine/dbal` is already resolved to `4.4.4`, so the lock file only
records the changed content hash.

[1] https://github.com/doctrine/dbal/releases/tag/4.4.4

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1621

  1. Stefan Bürk uploaded patch set 1 08/11/26, 13:29

  2. core-ci voted on patch set 1 V +1 08/11/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106441

  3. Stefan Bürk updated the commit message in patch set 2 V +1 08/11/26, 14:14

  4. Stefan Bürk commented on patch set 2 08/11/26, 14:15

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 08/11/26, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106447

  6. Oliver Klee voted on patch set 2 CR +1 V +1 08/11/26, 14:32

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 08/11/26, 15:58

  8. Stefan Bürk commented on patch set 2 CR -2 08/11/26, 16:12

    Blocking merge - requires the previous changes in the relation chain to be merged first.
  9. Stefan Bürk uploaded patch set 3 CR +1 V +1 08/14/26, 20:48

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. core-ci voted on patch set 3 V +1 08/14/26, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106723

  11. Stefan Bürk uploaded patch set 4 V +1 08/31/26, 10:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  12. core-ci voted on patch set 4 V +1 08/31/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107407

  13. Oliver Klee voted on patch set 4 CR +1 V +1 08/31/26, 11:16

  14. Stefan Bürk rebased onto patch set 5 CR +1 V +1 09/02/26, 10:40

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. Stefan Bürk commented on patch set 5 CR 0 09/02/26, 10:41

    Reply

    Blocking pre-changes has been merged.
  16. Josua Vogel voted on patch set 5 CR +1 V +1 09/02/26, 10:48

  17. core-ci voted on patch set 5 V +1 09/02/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107592

  18. Oliver Klee voted on patch set 5 CR +1 V +1 09/02/26, 11:01

  19. Benni Mack voted on patch set 5 CR +1 V +1 09/02/26, 11:09

  20. Stefan Bürk voted on patch set 5 CR +2 V +2 09/02/26, 11:37

  21. Stefan Bürk merged patch set 6 09/02/26, 12:16