Review 13.4 Merged

95264[BUGFIX] Prevent `f:render.text` errors without TCA record type

Matthias Vogel CR +2 V +2 Easy +24 −1 updated 08/12/26, 08:59

Commit message

Do not resolve a record type for Extbase models mapped to tables
that do not define a TCA type field. This avoids unrelated properties
triggering a TypeError during text rendering.

This issue does not occur in TYPO3 >= 14, where the check is already
in place.

The return type of DataMap->getRecordTypeColumnName() is incorrectly
declared as string instead of ?string. Since this is fixed in
newer TYPO3 versions, the issue is only added to the PHPStan baseline.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Matthias Vogel uploaded patch set 1 08/11/26, 14:59

  2. core-ci voted on patch set 1 V -1 08/11/26, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106455

  3. Matthias Vogel uploaded patch set 2 V -1 08/11/26, 15:15

  4. Matthias Vogel updated the commit message in patch set 3 08/11/26, 15:16

  5. Matthias Vogel marked it ready for review 08/11/26, 15:19

  6. core-ci voted on patch set 2 V +1 08/11/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106456

  7. core-ci voted on patch set 3 V +1 08/11/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106457

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 08/11/26, 15:52

  9. Georg Ringer voted on patch set 3 CR +1 V +1 08/11/26, 16:24

  10. Sven Liebert voted on patch set 3 CR +1 V +1 08/12/26, 06:10

  11. Benni Mack voted on patch set 3 CR +2 V +2 08/12/26, 08:59

  12. Benni Mack merged patch set 4 08/12/26, 08:59