Review main Merged

95266[TASK] Replace deprecated spl_object_hash() calls

Stefan Bürk CR +2 V +2 Hard +265 −11 updated 11/01/26, 12:46

Commit message

PHP 8.6 deprecates spl_object_hash(). Use spl_object_id() for
request-local route names, debugger anchors and form validator cache
keys. The objects remain alive while their identifiers are in use.

Separate plugin namespaces from decimal object IDs in route names to
avoid ambiguous concatenation when a namespace ends in digits. Prefix
debugger anchors with object- and keep recurring-object links aligned.

Tests cover route-name uniqueness and namespace boundaries, recurring
debugger links and independent validators for distinct renderables.

The current PHP 8.6.0alpha3 testing image predates this deprecation.
Retain WIP status until the Forge issue and newer runtime checks are
available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 913

  1. Stefan Bürk uploaded patch set 1 08/11/26, 18:35

  2. core-ci voted on patch set 1 V +1 08/11/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106461

  3. Wouter Wolters uploaded patch set 2 V +1 11/01/26, 10:23

  4. Wouter Wolters updated the commit message in patch set 3 11/01/26, 10:31

  5. core-ci voted on patch set 2 V -1 11/01/26, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113001

  6. Benni Mack marked it ready for review 11/01/26, 10:41

  7. Wouter Wolters voted on patch set 3 CR +1 V +1 11/01/26, 10:42

  8. core-ci voted on patch set 3 V -1 11/01/26, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113005

  9. Wouter Wolters rebased onto patch set 4 CR +1 V +1 11/01/26, 11:02

  10. Wouter Wolters voted on patch set 4 CR +1 V +1 11/01/26, 11:02

  11. core-ci voted on patch set 4 V +1 11/01/26, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113009

  12. Benni Mack voted on patch set 4 CR +2 V +2 11/01/26, 12:46

  13. Benni Mack merged patch set 5 11/01/26, 12:46