Review main Merged

95267[TASK] Use spl_object_id() for ObjectStorage keys

Stefan Bürk CR +2 V +2 Normal +104 −28 updated 11/02/26, 06:12

Commit message

PHP 8.6 deprecates spl_object_hash(). Use object IDs for storage and
relation-tracking keys while keeping key() declared to return string.
Its opaque value changes from a hexadecimal hash to a decimal ID.
Positional access continues to resolve through array_values().

Update the serialization paths added on main since patch set 1. Save
objects as a plain list and rebuild their storage and tracking keys on
restoration, since object IDs are local to the current process.

Tests cover string iterator keys, distinct object identities, restored
information and positions, detach behavior and dirty relation tracking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 912

  1. Stefan Bürk uploaded patch set 1 08/11/26, 18:35

  2. core-ci voted on patch set 1 V +1 08/11/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106462

  3. Wouter Wolters uploaded patch set 2 V +1 11/01/26, 10:23

  4. core-ci voted on patch set 2 V -1 11/01/26, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113002

  5. Wouter Wolters rebased onto patch set 3 V -1 11/01/26, 13:25

  6. core-ci voted on patch set 3 V +1 11/01/26, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113019

  7. Wouter Wolters voted on patch set 3 CR +1 V +1 11/01/26, 13:37

  8. Benni Mack marked it ready for review 11/01/26, 14:07

  9. Oliver Klee voted on patch set 3 V +1 11/01/26, 14:30

  10. Oliver Klee voted on patch set 3 CR +1 11/01/26, 14:31

  11. Benni Mack voted on patch set 3 CR +2 V +2 11/02/26, 06:12

  12. Benni Mack merged patch set 4 11/02/26, 06:12