95268[TASK] Replace deprecated SORT_LOCALE_STRING flag
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CountrySelectViewHelperTest.php+33 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+66 −0
Review log 1824
-
Stefan Bürk uploaded patch set 1 08/11/26, 18:35
-
core-ci voted on patch set 1 V +1 08/11/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106463
-
Wouter Wolters uploaded patch set 2
V +111/01/26, 10:23 -
core-ci voted on patch set 2 V -1 11/01/26, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113003
-
Wouter Wolters uploaded patch set 3
V -111/01/26, 11:26 -
core-ci voted on patch set 3 V +1 11/01/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113010
-
Wouter Wolters updated the commit message in patch set 4
V +111/01/26, 12:51 -
Wouter Wolters updated the commit message in patch set 5 11/01/26, 12:51
-
Wouter Wolters updated the commit message in patch set 6 11/01/26, 12:52
-
core-ci voted on patch set 6 V +1 11/01/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113017
-
Wouter Wolters voted on patch set 6 CR +1 V +1 11/01/26, 13:37
-
Benni Mack marked it ready for review 11/01/26, 21:11
-
Benni Mack commented on patch set 6 11/01/26, 21:13
we _could_ theoretically check for the PHP version and keep the old behavior for older versions -
Benni Mack commented on patch set 6 CR -1 11/01/26, 21:13
The important RST has the wrong issue number -
Wouter Wolters commented on patch set 6 11/01/26, 21:20
Reply
I removed the RST in patchset 3 already. -
Oliver Klee voted on patch set 6 CR +1 V +1 11/01/26, 21:28
-
Benni Mack commented on patch set 6 11/02/26, 05:39
Reply
Done -
Wouter Wolters uploaded patch set 7
CR +1V +111/04/26, 18:15 -
Wouter Wolters voted on patch set 7 CR +1 V +1 11/04/26, 18:27
-
Oliver Klee voted on patch set 7 CR +1 V +1 11/04/26, 18:31
-
core-ci voted on patch set 7 V -1 11/04/26, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113311
-
core-ci voted on patch set 7 V +1 11/04/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113311
-
Benni Mack commented on patch set 7 CR +2 V +2 11/04/26, 20:29
Reply
Done -
Benni Mack merged patch set 8 11/04/26, 20:29