95271[BUGFIX] Limit translation lookup to records page
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 2
Files 4
Review log 1827
Show 12 earlier messages
-
Stephan Salzmann uploaded patch set 1 08/11/26, 18:48
-
core-ci voted on patch set 1 V +1 08/11/26, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106466
-
Benni Mack updated the commit message in patch set 2
V +108/11/26, 20:34 -
Benni Mack updated the commit message in patch set 3 08/11/26, 20:35
-
core-ci voted on patch set 2 V +1 08/11/26, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106469
-
core-ci voted on patch set 3 V +1 08/11/26, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106470
-
Benni Mack updated the commit message in patch set 4
V +108/12/26, 05:44 -
core-ci voted on patch set 4 V +1 08/12/26, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106485
-
Stephan Salzmann uploaded patch set 5 08/12/26, 06:04
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 5 V +1 08/12/26, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106486
-
Bastien Lutz voted on patch set 5 CR +1 V +1 08/12/26, 06:29
-
Wouter Wolters commented on patch set 5 08/12/26, 13:23
typo3/sysext/backend/Classes/Controller/EditDocumentController.php:1239 has also both uid and pid available. Maybe change that too to send both instead of only uid? -
Stephan Salzmann uploaded patch set 6
CR +1V +108/13/26, 13:37 -
Stephan Salzmann commented on patch set 6 08/13/26, 13:41
Reply
$this->firstEl is of type TYPO3\CMS\Backend\Dto\FormElementData and not a RecordInterface expected by getRecordTranslations(). So I dont't change this line. -
core-ci voted on patch set 6 V +1 08/13/26, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106655
-
Wouter Wolters commented on patch set 6 08/13/26, 15:06
Reply
I think you can just build the array with uid and pid. That is only needed there. Doesn't need to be of type RecordInterface -
Stephan Salzmann uploaded patch set 7
V +108/13/26, 19:02 -
core-ci voted on patch set 7 V +1 08/13/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106671
-
Wouter Wolters commented on patch set 7 08/14/26, 09:33
EditDocumentController.php:1241this needs to be ['uid' => (int)$this->firstEl->uid, 'pid' => (int)$this->firstEl->pid] otherwise it doesn't work. -
Stephan Salzmann uploaded patch set 8
V +108/14/26, 11:50 -
Stephan Salzmann commented on patch set 8 08/14/26, 11:51
EditDocumentController.php:1241ReplyI have fixed the array. Sorry, I was in hurry yesterday. -
core-ci voted on patch set 8 V +1 08/14/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106697
-
Stephan Salzmann rebased onto patch set 9
V +108/14/26, 18:26 -
core-ci voted on patch set 9 V +1 08/14/26, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106711
-
Wouter Wolters voted on patch set 9 CR +1 V +1 09/01/26, 19:42
-
Benni Mack voted on patch set 9 CR +2 V +2 09/02/26, 05:06
-
Benni Mack merged patch set 10 09/02/26, 05:06