Review main Merged

95273[BUGFIX] Fix PageRendererFactoryTrait

Simon Schaufelberger CR +2 V +2 Easy +29 −2 updated 09/07/26, 19:56

Commit message

Since ResourceHashCollection became a final class, the tests in the
PageRendererFactoryTrait were not adjusted as this trait has no more
usage in any tests. Re-add a test to cover this trait.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1215

  1. Simon Schaufelberger uploaded patch set 1 08/11/26, 21:30

  2. core-ci voted on patch set 1 V +1 08/11/26, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106471

  3. Simon Schaufelberger rebased onto patch set 2 V +1 09/01/26, 21:22

  4. Wouter Wolters voted on patch set 2 CR +1 V +1 09/01/26, 21:23

  5. core-ci voted on patch set 2 V -1 09/01/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107537

  6. Benni Mack commented on patch set 2 CR -1 09/02/26, 04:52

    @simonschaufi+typo3@gmail.com can you please fix the tests on main?
  7. Wouter Wolters uploaded patch set 3 CR +1 V +1 09/02/26, 16:19

  8. core-ci voted on patch set 3 V +1 09/02/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107654

  9. Benni Mack voted on patch set 3 CR +1 V +1 09/02/26, 16:29

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/02/26, 18:32

  11. Oliver Klee voted on patch set 3 CR +1 V +1 09/02/26, 19:02

  12. Josua Vogel voted on patch set 3 CR +1 V +1 09/07/26, 06:27

  13. Wouter Wolters voted on patch set 3 CR +1 V +1 09/07/26, 18:56

  14. Stefan Bürk voted on patch set 3 CR +2 V +2 09/07/26, 19:05

  15. Stefan Bürk merged patch set 4 09/07/26, 19:56