Review main Abandoned

95274[BUGFIX] Tighten DB query for translation lookup in the RecordProvider

Stephan Salzmann CR +1 V +1 Easy +1 −1 updated 08/13/26, 13:42

Commit message

Handing over the Record object allows the LocalizationRepository
to also limit the DB query to the "pid" instead of just
the "uid" making the resulting DB result set tighter.

Review

  • Code review CR +1
    • Bastien Lutz +1
  • Verified V +1
    • Bastien Lutz +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Stephan Salzmann uploaded patch set 1 08/12/26, 06:04

  2. core-ci voted on patch set 1 V +1 08/12/26, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106487

  3. Bastien Lutz voted on patch set 1 CR +1 V +1 08/12/26, 06:30

  4. Benni Mack commented on patch set 1 08/12/26, 06:46

    Stephan, great stuff!
  5. Wouter Wolters commented on patch set 1 08/12/26, 13:20

    I think this change needs to go into https://review.typo3.org/c/Packages/TYPO3.CMS/+/95271 You now have 2 separate patches for the same Forge ticket.
  6. Stephan Salzmann commented on patch set 1 08/13/26, 06:13

    Reply Unresolved

    Sorry for that. I had have made my changes for my first patch as here described: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/HandlingAPatch/CherryPick.html I will look how I can fix that.
  7. Stephan Salzmann abandoned the change 08/13/26, 13:42