95276[TASK] Use stubs for test doubles without expectations, part 2
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 85
- typo3/sysext/adminpanel/Tests/Unit/Service/ProcessedImageCollectorTest.php+7 −7
- typo3/sysext/adminpanel/Tests/Unit/Utility/StateUtilityTest.php+4 −4
- typo3/sysext/backend/Tests/Functional/View/Event/AfterPageContentPreviewRenderedTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/ElementBrowser/Event/IsFileSelectableEventTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OnTheFlyTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+20 −33
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+5 −5
- typo3/sysext/core/Tests/Functional/DependencyInjection/AsFileRendererAttributeTest.php+6 −6
- typo3/sysext/core/Tests/Functional/Resource/ResourceFactoryTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Command/Descriptor/TextDescriptorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+2 −2
Show 65 more files
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/Localization/StateTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/ImageDimensionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+2 −6
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+2 −6
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+2 −6
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Messenger/HandlersLocatorFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Messenger/TransportLocatorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Middleware/VerifyHostHeaderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+19 −19
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ListUtilityTest.php+4 −6
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php+5 −4
- typo3/sysext/filelist/Tests/Unit/Event/ModifyEditFileFormDataEventTest.php+1 −1
- typo3/sysext/filelist/Tests/Unit/Matcher/ResourceFileExtensionMatcherTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+4 −4
- typo3/sysext/form/Tests/Unit/DependencyInjection/FormYamlCollectorConfiguratorTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+4 −4
- typo3/sysext/form/Tests/Unit/Domain/FormElements/FileUploadTest.php+2 −2
- typo3/sysext/form/Tests/Unit/EventListener/FormatDateRenderableBeforeRenderingTest.php+4 −4
- typo3/sysext/form/Tests/Unit/EventListener/TranslateDefaultValueBeforeRenderingTest.php+7 −7
- typo3/sysext/form/Tests/Unit/Service/CleanupFormUploadsServiceTest.php+25 −25
- typo3/sysext/form/Tests/Unit/Service/FormEditorEnrichmentServiceTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Service/RichTextConfigurationServiceTest.php+9 −9
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ImageContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+6 −6
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Service/Typo3tempFileServiceTest.php+4 −4
- typo3/sysext/install/Tests/Unit/SystemEnvironment/DatabaseCheck/Platform/MySqlTest.php+1 −1
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+16 −16
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+23 −22
- typo3/sysext/reports/Tests/Unit/Report/Status/Typo3StatusTest.php+1 −1
- typo3/sysext/reports/Tests/Unit/Service/StatusServiceTest.php+2 −2
- typo3/sysext/seo/Tests/Unit/HrefLang/HrefLangGeneratorTest.php+2 −2
- typo3/sysext/seo/Tests/Unit/XmlSitemap/XmlSitemapFactoryTest.php+2 −2
Review log 89
-
Benni Mack uploaded patch set 1 08/12/26, 06:16
-
core-ci voted on patch set 1 V +1 08/12/26, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106490
-
Wouter Wolters voted on patch set 1 CR +1 V +1 08/12/26, 07:55
-
Oliver Klee voted on patch set 1 CR +1 V +1 08/12/26, 08:07
-
Benni Mack voted on patch set 1 CR +2 V +2 08/12/26, 08:10
-
Benni Mack voted on patch set 1 CR 0 V 0 08/12/26, 08:10
-
Georg Ringer voted on patch set 1 CR +1 V +1 08/12/26, 10:01
-
Benni Mack voted on patch set 1 CR +2 V +2 08/12/26, 10:06
-
Benni Mack merged patch set 2 08/12/26, 10:06