95279[TASK] Use dependency injection for the code editor configuration
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/CodeEditor/Registry/AddonRegistry.phpdeleted+0 −61
- typo3/sysext/backend/Classes/CodeEditor/Registry/ModeRegistry.phpdeleted+0 −99
- typo3/sysext/backend/Classes/CodeEditor/Addon.php+8 −67
- typo3/sysext/backend/Classes/CodeEditor/CodeEditor.phpdeleted+0 −146
- typo3/sysext/backend/Classes/CodeEditor/CodeEditorConfiguration.phpnew+218 −0
- typo3/sysext/backend/Classes/CodeEditor/Mode.php+8 −61
- typo3/sysext/backend/Classes/EventListener/InitializeCodeEditorInEditFileForm.php+6 −11
- typo3/sysext/backend/Classes/Form/Element/CodeEditorElement.php+16 −23
- typo3/sysext/backend/Classes/Form/Element/JsonElement.php+15 −17
- typo3/sysext/backend/Tests/Functional/CodeEditor/CodeEditorConfigurationTest.phpnew+53 −0
- typo3/sysext/backend/Tests/Unit/CodeEditor/Registry/AddonRegistryTest.phpdeleted+0 −98
- typo3/sysext/backend/Tests/Unit/CodeEditor/Registry/ModeRegistryTest.phpdeleted+0 −72
- typo3/sysext/backend/Tests/Unit/CodeEditor/CodeEditorConfigurationTest.phpnew+215 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.php+5 −20
- typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php+6 −10
- typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.php+6 −10
Review log 89
-
Benni Mack uploaded patch set 1 08/12/26, 10:12
-
core-ci voted on patch set 1 V +1 08/12/26, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106495
-
Benni Mack marked it ready for review 08/12/26, 10:36
-
Stefan Bürk voted on patch set 1 CR +1 08/12/26, 16:15
-
Stefan Bürk voted on patch set 1 V +1 08/12/26, 19:22
-
Oliver Klee voted on patch set 1 V +1 08/12/26, 20:00
-
Georg Ringer voted on patch set 1 CR +1 V +1 08/13/26, 06:39
-
Benni Mack commented on patch set 1 CR +2 V +2 08/13/26, 06:52
thank you -
Benni Mack merged patch set 2 08/13/26, 06:52