Review main Merged

95283[TASK] Make UserAspect an immutable snapshot

Benni Mack CR +2 V +2 Normal +57 −44 updated 08/13/26, 18:15

Commit message

The user aspect now captures all information (id, username, admin
flag, group ids and names) at the time it is created, instead of
reading from the mutable user authentication object on every access.
Code changing the state of a user object needs to set a freshly
created aspect afterwards to make the change visible - which is
already the case everywhere in TYPO3 Core. The one newly required
spot is the evaluation of user TSconfig conditions during backend
login initialization, which now refreshes the aspect right after the
group data of the user has been resolved.

In addition, the distinction between frontend and backend users is
now derived from the login type of the user object, removing the
dependency of EXT:core onto the FrontendUserAuthentication class of
EXT:frontend.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Sascha Nowak +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1115

  1. Benni Mack uploaded patch set 1 08/12/26, 11:34

  2. core-ci voted on patch set 1 V -1 08/12/26, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106513

  3. Benni Mack rebased onto patch set 2 V -1 08/12/26, 12:05

  4. Benni Mack abandoned the change 08/12/26, 12:06

    should be merged
  5. Benni Mack restored the change 08/12/26, 12:45

  6. Benni Mack uploaded patch set 3 08/12/26, 12:45

  7. Benni Mack updated the commit message in patch set 4 08/12/26, 12:46

  8. Benni Mack marked it ready for review 08/12/26, 12:46

  9. core-ci voted on patch set 4 V -1 08/12/26, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106538

  10. core-ci voted on patch set 3 V +1 08/12/26, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106537

  11. core-ci voted on patch set 4 V +1 08/12/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106538

  12. Georg Ringer voted on patch set 4 CR +1 V +1 08/13/26, 17:35

  13. Sascha Nowak voted on patch set 4 CR +1 V +1 08/13/26, 17:56

  14. Stefan Bürk voted on patch set 4 CR +2 V +2 08/13/26, 18:15

  15. Stefan Bürk merged patch set 5 08/13/26, 18:15