95284[TASK] Authenticate users via the auth pipeline
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Josua Vogel +1
- core-ci +1 CI
Issues 3
Files 12
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php4+45 −94
- typo3/sysext/backend/Classes/Security/LegacyBackendAuthenticator.phpnew+107 −0
- typo3/sysext/backend/Classes/Security/MfaChallengeResponseFactory.phpnew+75 −0
- typo3/sysext/backend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.php+288 −8
- typo3/sysext/core/Classes/Authentication/Pipeline/LegacyUserPrincipalFactory.phpnew+108 −0
- typo3/sysext/core/Classes/Authentication/Pipeline/LoginRateLimiterGuard.phpnew+61 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+11 −2
- typo3/sysext/core/Tests/Functional/Authentication/Pipeline/LegacyUserPrincipalFactoryTest.phpnew+121 −0
- typo3/sysext/core/Tests/Unit/Authentication/Pipeline/LoginRateLimiterGuardTest.phpnew+75 −0
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+21 −52
- typo3/sysext/frontend/Classes/Security/LegacyFrontendAuthenticator.phpnew+77 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/FrontendUserAuthenticatorTest.phpnew+201 −0
Review log 3454
Show 1629 earlier messages
-
Benni Mack uploaded patch set 1 08/12/26, 11:34
-
core-ci voted on patch set 1 V -1 08/12/26, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106514
-
Benni Mack rebased onto patch set 2
V -108/12/26, 12:05 -
Benni Mack uploaded patch set 3 08/12/26, 12:08
-
core-ci voted on patch set 2 V -1 08/12/26, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106523
-
core-ci voted on patch set 3 V -1 08/12/26, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106529
-
Benni Mack rebased onto patch set 4
V -110/05/26, 17:00 -
core-ci voted on patch set 4 V -1 10/05/26, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110132
-
Benni Mack uploaded patch set 5
V -110/05/26, 18:16 -
core-ci voted on patch set 5 V +1 10/05/26, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110141
-
Benni Mack uploaded patch set 6
V +110/06/26, 04:50 -
core-ci voted on patch set 6 V -1 10/06/26, 05:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110170
-
Benni Mack rebased onto patch set 7
V -110/06/26, 05:53 -
core-ci voted on patch set 7 V +1 10/06/26, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110181
-
Benni Mack rebased onto patch set 8
V +110/06/26, 08:11 -
core-ci voted on patch set 8 V +1 10/06/26, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110203
-
Simon Schaufelberger commented on patch set 8 10/06/26, 18:47
I'm happy to see progress in that area of TYPO3! I would like to know: Is that concept built upon a standard or implemented only for TYPO3? I'm just thinking if it would be compatible to plug in third party auth providers easily like the ones from https://github.com/thephpleague/oauth2-client ? I'm not sure how Symfony is doing that because we already use a lot of components from them. Do you know how they do auth? It would also be good to reduce the number of auth extensions in the TER https://extensions.typo3.org/?L=0&id=1&tx_solr%5Bq%5D=auth and finally build a good foundation that most of them are not needed anymore. -
Oli Bartsch uploaded patch set 9
V +110/09/26, 10:18 -
Oli Bartsch commented on patch set 9 10/09/26, 10:24
This change is ready for review.Reply
The design follows the authenticator model of Symfony and Laravel but stays PSR-7/PSR-15 native instead of adopting Symfony Security, so a provider built on league/oauth2-client plugs in as an AuthenticatorInterface implementation. An OIDC login on top of it is planned for a later phase. -
core-ci voted on patch set 9 V -1 10/09/26, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110580
-
Oli Bartsch rebased onto patch set 10
V -110/09/26, 13:01 -
Oli Bartsch uploaded patch set 11 10/09/26, 13:03
-
core-ci voted on patch set 11 V +1 10/09/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110609
-
core-ci voted on patch set 10 V +1 10/09/26, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110606
-
Oli Bartsch rebased onto patch set 12
V +110/09/26, 20:49 -
core-ci voted on patch set 12 V +1 10/09/26, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110719
-
Oli Bartsch uploaded patch set 13
V +110/12/26, 12:32 -
Markus Klein commented on patch set 13 10/12/26, 12:41
Reply
@bo@cedev.de Regarding OIDC: I would be honored if you could keep me in the loop here. Reason: I don't wanna invest time into ext:oidc if this is going to be superseded then anyways. Besides that: I'm currently one step away to try getting all current Oauth2 extension maintainers onto a table. We have so much duplicate code out there that it would be beneficial to have that burden on less shoulders than currently. Of course, if we manage to get some of the basics into Core, that's would be even better. Let me know, what your ideas are. Thanks. -
core-ci voted on patch set 13 V +1 10/12/26, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110905
-
Oli Bartsch rebased onto patch set 14
V +110/12/26, 19:57 -
core-ci voted on patch set 14 V +1 10/12/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110941
-
Benjamin Franzke commented on patch set 14 10/23/26, 12:55
BackendUserAuthenticator.php:136It feels like we should differentiate between an intermediate `Principal` that is provided by `AuthenticatorInterface->authenticate()` and the kind of `Principal` that built here and **derived** from the original (i call it intermediate) `Principal` and the resolved group data. (If you remember: Otherwise it's similar to our `new Locale('de')` case create by `SiteLanguage` which is incomplete and needs to be recreated later) -
Benni Mack uploaded patch set 15
V +110/25/26, 13:55 -
core-ci voted on patch set 15 V +1 10/25/26, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112494
-
Oliver Klee voted on patch set 15 V +1 10/25/26, 14:52
-
Oli Bartsch uploaded patch set 16
V +110/25/26, 19:39 -
core-ci voted on patch set 16 V +1 10/25/26, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112538
-
Benni Mack uploaded patch set 17
V +110/26/26, 19:41 -
Benni Mack commented on patch set 17 10/26/26, 19:42
BackendUserAuthenticator.php:136ReplyThe backend authenticators now resolve the group data before they establish the principal, as the frontend did already, so the principal of the outcome is the final one and the middleware no longer rebuilds it. Your remark helped shape that process now better. -
core-ci voted on patch set 17 V +1 10/26/26, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112605
-
Oliver Klee voted on patch set 17 V +1 10/26/26, 21:09
-
Oli Bartsch uploaded patch set 18
V +110/29/26, 17:23 -
Oli Bartsch voted on patch set 18 CR +1 V +1 10/29/26, 17:26
-
core-ci voted on patch set 18 V +1 10/29/26, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112803
-
Benni Mack commented on patch set 18 10/30/26, 22:50
BackendUserAuthenticator.php:136ReplyThought about it again and I'm still not 100% happy with it (mainly because we mix group resolving still and identity management). However, I'd like to this in a followup once Authorization chain is also prepared. Would this be OK for you now and we will add this as a followup? -
Benni Mack uploaded patch set 19
CR +1V +111/03/26, 14:43 -
core-ci voted on patch set 19 V +1 11/03/26, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113161
-
Benjamin Franzke commented on patch set 19 11/06/26, 14:26
BackendUserAuthenticator.php:136Replyyup, fine by me. thanks! -
Benni Mack rebased onto patch set 20
V +111/09/26, 10:12 -
core-ci voted on patch set 20 V +1 11/09/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113637
-
Josua Vogel voted on patch set 20 CR +1 V +1 11/10/26, 15:25
-
Georg Ringer voted on patch set 20 CR +1 V +1 11/10/26, 18:07
-
Benni Mack voted on patch set 20 CR +2 V +2 11/10/26, 18:09
-
Benni Mack merged patch set 21 11/10/26, 18:09