Review main Merged

95287[FEATURE] Add native backend authenticators

Benni Mack CR +2 V +2 Expert +1090 −8 updated 11/17/26, 14:26

Commit message

Backend session resolution and password evaluation are now available as
native pipeline authenticators, no longer depending on the legacy
T3_SERVICES authentication service chain:

* PasswordAuthenticator processes submitted credentials - bound to
  the backend login routes, including the request token gate, rate
  limiting, hash timing mimicry, password rehashing, session fixation
  protection and the established logging and PSR-14 events.
* SessionAuthenticator resolves an existing user session, handles
  logout requests and expired sessions, and initiates the
  multi-factor authentication challenge when required.
* Users are looked up through LocalIdentityProvider, the single place
  querying be_users records with the enable-column handling.

The native authenticators only engage when the core authentication
service is the only available authentication service. As soon as an
extension adds an available authentication service, the core service is
disabled or its class is replaced, a postUserLookUp hook is registered
or the chain behavior is modified via SVCONF, LegacyAuthServiceDetector
disables them and the wrapped legacy service chain processes the request
exactly as before, keeping all existing extensions working. Services
that are not available are ignored, as the legacy chain never runs them.

As a deliberate behavior change of the native path, credentials POSTed
to arbitrary backend URLs outside the login routes are ignored.

Login and logout requests are only processed for POST requests with the
login status in the request body, request parameters that are no strings
are ignored. Submitted credentials are trimmed as before.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 3963

Show 1938 earlier messages
  1. Benni Mack uploaded patch set 1 08/12/26, 11:34

  2. core-ci voted on patch set 1 V -1 08/12/26, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106517

  3. Benni Mack rebased onto patch set 2 V -1 08/12/26, 12:05

  4. Benni Mack uploaded patch set 3 08/12/26, 12:08

  5. core-ci voted on patch set 2 V -1 08/12/26, 12:34 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106526

  6. core-ci voted on patch set 3 V -1 08/12/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106532

  7. Benni Mack rebased onto patch set 4 V -1 10/05/26, 17:00

  8. core-ci voted on patch set 4 V -1 10/05/26, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110135

  9. Benni Mack uploaded patch set 5 10/05/26, 18:16

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  10. core-ci voted on patch set 5 V -1 10/05/26, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110142

  11. Benni Mack uploaded patch set 6 V -1 10/06/26, 04:50

  12. core-ci voted on patch set 6 V -1 10/06/26, 05:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110171

  13. Benni Mack rebased onto patch set 7 V -1 10/06/26, 05:53

  14. core-ci voted on patch set 7 V -1 10/06/26, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110182

  15. Benni Mack rebased onto patch set 8 V -1 10/06/26, 08:11

  16. core-ci voted on patch set 8 V -1 10/06/26, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110204

  17. Oli Bartsch uploaded patch set 9 V -1 10/09/26, 10:50

  18. core-ci voted on patch set 9 V -1 10/09/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110590

  19. Oli Bartsch rebased onto patch set 10 V -1 10/09/26, 13:01

  20. Oli Bartsch rebased onto patch set 11 10/09/26, 13:03

  21. core-ci voted on patch set 10 V -1 10/09/26, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110607

  22. core-ci voted on patch set 11 V -1 10/09/26, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110610

  23. Oli Bartsch uploaded patch set 12 V -1 10/09/26, 20:49

  24. core-ci voted on patch set 12 V +1 10/09/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110720

  25. Oli Bartsch rebased onto patch set 13 V +1 10/12/26, 12:32

  26. core-ci voted on patch set 13 V +1 10/12/26, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110906

  27. Oli Bartsch rebased onto patch set 14 V +1 10/12/26, 19:57

  28. core-ci voted on patch set 14 V +1 10/12/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110942

  29. Benni Mack uploaded patch set 15 V +1 10/25/26, 13:55

  30. core-ci voted on patch set 15 V +1 10/25/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112495

  31. Oli Bartsch uploaded patch set 16 V +1 10/25/26, 19:39

  32. core-ci voted on patch set 16 V +1 10/25/26, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112539

  33. Benni Mack uploaded patch set 17 V +1 10/26/26, 19:41

  34. core-ci voted on patch set 17 V +1 10/26/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112606

  35. Benni Mack rebased onto patch set 18 V +1 11/03/26, 14:43

  36. core-ci voted on patch set 18 V -1 11/03/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113162

  37. Benni Mack rebased onto patch set 19 V -1 11/09/26, 10:12

  38. core-ci voted on patch set 19 V +1 11/09/26, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113638

  1. Benni Mack uploaded patch set 20 V +1 11/10/26, 20:26

  2. core-ci voted on patch set 20 V +1 11/10/26, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113945

  3. Benni Mack marked it ready for review 11/10/26, 22:10

  4. Wouter Wolters voted on patch set 20 CR +1 V +1 11/11/26, 22:22

  5. Josua Vogel commented on patch set 20 CR -1 11/13/26, 08:59

    If I switch from my admin user (no MFA enabled) to a user with MFA enabled, I must enter the MFA (not possible). Maybe we can skip the MFA when switching user?
  6. Benni Mack uploaded patch set 21 CR +1 V +1 11/13/26, 14:31

  7. Benni Mack commented on patch set 21 11/13/26, 14:47

    Reply

    good catch. MFA + Switch-User. Now solved and a test added.
  8. core-ci voted on patch set 21 V +1 11/13/26, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114337

  9. Josua Vogel voted on patch set 21 CR +1 V +1 11/13/26, 17:12

  10. Simon Schaufelberger commented on patch set 21 11/13/26, 18:42

    PasswordAuthenticator.php:185

    above we always have `\'%s\'` for the username. here without. make it consistent?

    SessionAuthenticator.php:86

    using quotes? where ist he username actually loaded from? I don't see the parameter that is passed to %s

    SessionAuthenticator.php:88

    should we log the username similar like: User {username} logged in from {ip}?
  11. Benni Mack uploaded patch set 22 CR +1 V +1 11/13/26, 19:02

  12. Benni Mack commented on patch set 21 11/13/26, 19:03

    PasswordAuthenticator.php:185 Reply

    Done.

    SessionAuthenticator.php:86 Reply

    Done.

    SessionAuthenticator.php:88 Reply

    Done.
  13. core-ci voted on patch set 22 V +1 11/13/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114373

  14. Benni Mack uploaded patch set 23 V +1 11/13/26, 20:59

  15. Simon Schaufelberger voted on patch set 23 CR +1 V +1 11/13/26, 22:23

  16. core-ci voted on patch set 23 V +1 11/13/26, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114395

  17. Josua Vogel voted on patch set 23 CR +1 V +1 11/14/26, 17:18

  18. Georg Ringer commented on patch set 23 11/14/26, 18:10

    SessionAuthenticator.php:82

    should we allow POST only as with the login?

    LegacyAuthServiceDetector.php:40

    should we also check if a service is disabled?
  19. Oli Bartsch uploaded patch set 24 CR +1 V +1 11/17/26, 10:10

  20. Oli Bartsch commented on patch set 24 11/17/26, 10:17

    SessionAuthenticator.php:82 Reply

    Done. On the native path a logout via login_status is now only processed from the body of a POST request, like the login. The legacy path is unchanged.

    LegacyAuthServiceDetector.php:40 Reply

    Yes, done. Only available services count now, matching ExtensionManagementUtility::findService(). A disabled core AuthenticationService now routes to the legacy chain. Before, the native path would have accepted passwords there. The detector also falls back to legacy when the core service class is replaced (className or XCLASS) or a postUserLookUp hook is registered.
  21. core-ci voted on patch set 24 V +1 11/17/26, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114685

  22. Josua Vogel voted on patch set 24 CR +1 V +1 11/17/26, 12:15

  23. Oli Bartsch voted on patch set 24 CR +1 V +1 11/17/26, 14:10

  24. Benni Mack voted on patch set 24 CR +2 V +2 11/17/26, 14:26

  25. Benni Mack merged patch set 25 11/17/26, 14:26