95287[FEATURE] Add native backend authenticators
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+3 −2
- typo3/sysext/backend/Classes/Security/LegacyBackendAuthenticator.php+13 −3
- typo3/sysext/backend/Classes/Security/MfaChallengeResponseFactory.php+50 −3
- typo3/sysext/backend/Classes/Security/PasswordAuthenticator.php2new+317 −0
- typo3/sysext/backend/Classes/Security/SessionAuthenticator.php6new+142 −0
- typo3/sysext/backend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.php+121 −0
- typo3/sysext/backend/Tests/Functional/Security/MfaChallengeResponseFactoryTest.phpnew+83 −0
- typo3/sysext/backend/Tests/Functional/Security/SessionAuthenticatorTest.phpnew+88 −0
- typo3/sysext/core/Classes/Authentication/Pipeline/LegacyAuthServiceDetector.php2new+66 −0
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+24 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111399-NativeBackendAuthenticators.rstnew+64 −0
- typo3/sysext/core/Tests/Unit/Authentication/Pipeline/LegacyAuthServiceDetectorTest.phpnew+119 −0
Review log 3963
Show 1938 earlier messages
-
Benni Mack uploaded patch set 1 08/12/26, 11:34
-
core-ci voted on patch set 1 V -1 08/12/26, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106517
-
Benni Mack rebased onto patch set 2
V -108/12/26, 12:05 -
Benni Mack uploaded patch set 3 08/12/26, 12:08
-
core-ci voted on patch set 2 V -1 08/12/26, 12:34 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106526
-
core-ci voted on patch set 3 V -1 08/12/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106532
-
Benni Mack rebased onto patch set 4
V -110/05/26, 17:00 -
core-ci voted on patch set 4 V -1 10/05/26, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110135
-
Benni Mack uploaded patch set 5 10/05/26, 18:16
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 5 V -1 10/05/26, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110142
-
Benni Mack uploaded patch set 6
V -110/06/26, 04:50 -
core-ci voted on patch set 6 V -1 10/06/26, 05:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110171
-
Benni Mack rebased onto patch set 7
V -110/06/26, 05:53 -
core-ci voted on patch set 7 V -1 10/06/26, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110182
-
Benni Mack rebased onto patch set 8
V -110/06/26, 08:11 -
core-ci voted on patch set 8 V -1 10/06/26, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110204
-
Oli Bartsch uploaded patch set 9
V -110/09/26, 10:50 -
core-ci voted on patch set 9 V -1 10/09/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110590
-
Oli Bartsch rebased onto patch set 10
V -110/09/26, 13:01 -
Oli Bartsch rebased onto patch set 11 10/09/26, 13:03
-
core-ci voted on patch set 10 V -1 10/09/26, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110607
-
core-ci voted on patch set 11 V -1 10/09/26, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110610
-
Oli Bartsch uploaded patch set 12
V -110/09/26, 20:49 -
core-ci voted on patch set 12 V +1 10/09/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110720
-
Oli Bartsch rebased onto patch set 13
V +110/12/26, 12:32 -
core-ci voted on patch set 13 V +1 10/12/26, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110906
-
Oli Bartsch rebased onto patch set 14
V +110/12/26, 19:57 -
core-ci voted on patch set 14 V +1 10/12/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110942
-
Benni Mack uploaded patch set 15
V +110/25/26, 13:55 -
core-ci voted on patch set 15 V +1 10/25/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112495
-
Oli Bartsch uploaded patch set 16
V +110/25/26, 19:39 -
core-ci voted on patch set 16 V +1 10/25/26, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112539
-
Benni Mack uploaded patch set 17
V +110/26/26, 19:41 -
core-ci voted on patch set 17 V +1 10/26/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112606
-
Benni Mack rebased onto patch set 18
V +111/03/26, 14:43 -
core-ci voted on patch set 18 V -1 11/03/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113162
-
Benni Mack rebased onto patch set 19
V -111/09/26, 10:12 -
core-ci voted on patch set 19 V +1 11/09/26, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113638
-
Benni Mack uploaded patch set 20
V +111/10/26, 20:26 -
core-ci voted on patch set 20 V +1 11/10/26, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113945
-
Benni Mack marked it ready for review 11/10/26, 22:10
-
Wouter Wolters voted on patch set 20 CR +1 V +1 11/11/26, 22:22
-
Josua Vogel commented on patch set 20 CR -1 11/13/26, 08:59
If I switch from my admin user (no MFA enabled) to a user with MFA enabled, I must enter the MFA (not possible). Maybe we can skip the MFA when switching user? -
Benni Mack uploaded patch set 21
CR +1V +111/13/26, 14:31 -
Benni Mack commented on patch set 21 11/13/26, 14:47
Reply
good catch. MFA + Switch-User. Now solved and a test added. -
core-ci voted on patch set 21 V +1 11/13/26, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114337
-
Josua Vogel voted on patch set 21 CR +1 V +1 11/13/26, 17:12
-
Simon Schaufelberger commented on patch set 21 11/13/26, 18:42
PasswordAuthenticator.php:185above we always have `\'%s\'` for the username. here without. make it consistent?SessionAuthenticator.php:86using quotes? where ist he username actually loaded from? I don't see the parameter that is passed to %sSessionAuthenticator.php:88should we log the username similar like: User {username} logged in from {ip}? -
Benni Mack uploaded patch set 22
CR +1V +111/13/26, 19:02 -
Benni Mack commented on patch set 21 11/13/26, 19:03
PasswordAuthenticator.php:185ReplyDone.SessionAuthenticator.php:86ReplyDone.SessionAuthenticator.php:88ReplyDone. -
core-ci voted on patch set 22 V +1 11/13/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114373
-
Benni Mack uploaded patch set 23
V +111/13/26, 20:59 -
Simon Schaufelberger voted on patch set 23 CR +1 V +1 11/13/26, 22:23
-
core-ci voted on patch set 23 V +1 11/13/26, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114395
-
Josua Vogel voted on patch set 23 CR +1 V +1 11/14/26, 17:18
-
Georg Ringer commented on patch set 23 11/14/26, 18:10
SessionAuthenticator.php:82should we allow POST only as with the login?LegacyAuthServiceDetector.php:40should we also check if a service is disabled? -
Oli Bartsch uploaded patch set 24
CR +1V +111/17/26, 10:10 -
Oli Bartsch commented on patch set 24 11/17/26, 10:17
SessionAuthenticator.php:82ReplyDone. On the native path a logout via login_status is now only processed from the body of a POST request, like the login. The legacy path is unchanged.LegacyAuthServiceDetector.php:40ReplyYes, done. Only available services count now, matching ExtensionManagementUtility::findService(). A disabled core AuthenticationService now routes to the legacy chain. Before, the native path would have accepted passwords there. The detector also falls back to legacy when the core service class is replaced (className or XCLASS) or a postUserLookUp hook is registered. -
core-ci voted on patch set 24 V +1 11/17/26, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114685
-
Josua Vogel voted on patch set 24 CR +1 V +1 11/17/26, 12:15
-
Oli Bartsch voted on patch set 24 CR +1 V +1 11/17/26, 14:10
-
Benni Mack voted on patch set 24 CR +2 V +2 11/17/26, 14:26
-
Benni Mack merged patch set 25 11/17/26, 14:26