Review main Merged

95288[FEATURE] Add native frontend authenticators

Benni Mack CR +2 V +2 Hard +810 −20 updated 11/17/26, 15:10

Commit message

Frontend session resolution and password evaluation are now available as
native pipeline authenticators, no longer depending on the legacy
T3_SERVICES authentication service chain:

* FrontendPasswordAuthenticator processes credentials submitted with
  "logintype=login" on any page URL - login forms placed on arbitrary
  pages (such as the felogin plugin) keep working as before, now with
  an explicit trigger instead of credential-sniffing on every
  request. The storage page restriction provided by the felogin form
  via the signed request token, permanent login handling
  ("stay logged in") and the established events are preserved.
* FrontendSessionAuthenticator resolves an existing user session and
  handles logout requests, always resolving group data so that group
  simulation keeps working.

Analogous to the backend, the native authenticators only engage when the
core authentication service is the only available authentication service
and no postUserLookUp hook or chain modifier is configured - otherwise
the wrapped legacy service chain handles the request unchanged.

Login requests are only processed for POST requests with the login type
in the request body, request parameters that are no strings are ignored.
Submitted credentials are trimmed as before. Logout links with
"logintype=logout" in the query string keep working.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 3761

Show 1836 earlier messages
  1. Benni Mack uploaded patch set 1 08/12/26, 11:34

  2. core-ci voted on patch set 1 V -1 08/12/26, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106518

  3. Benni Mack rebased onto patch set 2 V -1 08/12/26, 12:05

  4. Benni Mack uploaded patch set 3 08/12/26, 12:08

  5. core-ci voted on patch set 2 V -1 08/12/26, 12:34 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106527

  6. core-ci voted on patch set 3 V -1 08/12/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106533

  7. Benni Mack uploaded patch set 4 V -1 10/05/26, 17:00

  8. core-ci voted on patch set 4 V -1 10/05/26, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110136

  9. Benni Mack uploaded patch set 5 10/05/26, 18:16

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  10. core-ci voted on patch set 5 V -1 10/05/26, 18:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110143

  11. Benni Mack uploaded patch set 6 V -1 10/06/26, 04:50

  12. core-ci voted on patch set 6 V -1 10/06/26, 05:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110172

  13. Benni Mack rebased onto patch set 7 V -1 10/06/26, 05:53

  14. core-ci voted on patch set 7 V -1 10/06/26, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110183

  15. Benni Mack rebased onto patch set 8 V -1 10/06/26, 08:11

  16. core-ci voted on patch set 8 V -1 10/06/26, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110205

  17. Oli Bartsch uploaded patch set 9 V -1 10/09/26, 10:50

  18. core-ci voted on patch set 9 V -1 10/09/26, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110591

  19. Oli Bartsch rebased onto patch set 10 V -1 10/09/26, 13:01

  20. Oli Bartsch rebased onto patch set 11 10/09/26, 13:03

  21. core-ci voted on patch set 10 V -1 10/09/26, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110608

  22. core-ci voted on patch set 11 V -1 10/09/26, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110611

  23. Oli Bartsch rebased onto patch set 12 V -1 10/09/26, 20:49

  24. core-ci voted on patch set 12 V +1 10/09/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110721

  25. Oli Bartsch rebased onto patch set 13 V +1 10/12/26, 12:32

  26. core-ci voted on patch set 13 V +1 10/12/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110907

  27. Oli Bartsch rebased onto patch set 14 V +1 10/12/26, 19:57

  28. core-ci voted on patch set 14 V +1 10/12/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110943

  29. Benni Mack uploaded patch set 15 V +1 10/25/26, 13:55

  30. core-ci voted on patch set 15 V +1 10/25/26, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112496

  31. Oli Bartsch rebased onto patch set 16 V +1 10/25/26, 19:39

  32. core-ci voted on patch set 16 V +1 10/25/26, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112540

  33. Benni Mack rebased onto patch set 17 V +1 10/26/26, 19:41

  34. core-ci voted on patch set 17 V +1 10/26/26, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112607

  35. Benni Mack rebased onto patch set 18 V +1 11/03/26, 14:43

  36. core-ci voted on patch set 18 V +1 11/03/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113163

  1. Benni Mack rebased onto patch set 19 V +1 11/09/26, 10:12

  2. core-ci voted on patch set 19 V +1 11/09/26, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113639

  3. Benni Mack uploaded patch set 20 V +1 11/10/26, 20:26

  4. core-ci voted on patch set 20 V +1 11/10/26, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113946

  5. Benni Mack marked it ready for review 11/10/26, 22:10

  6. Benni Mack rebased onto patch set 21 V +1 11/13/26, 14:31

  7. core-ci voted on patch set 21 V +1 11/13/26, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114338

  8. Benni Mack rebased onto patch set 22 V +1 11/13/26, 19:02

  9. core-ci voted on patch set 22 V +1 11/13/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114374

  10. Benni Mack uploaded patch set 23 V +1 11/13/26, 20:59

  11. Simon Schaufelberger commented on patch set 23 11/13/26, 22:29

    FrontendSessionAuthenticator.php:70

    same as be: User {username} logged out. Id: {session}
  12. Oli Bartsch uploaded patch set 24 11/17/26, 10:10

  13. Oli Bartsch commented on patch set 24 11/17/26, 10:18

    FrontendSessionAuthenticator.php:70 Reply

    Done, same format as in the backend: "User {username} logged out. Id: {session}".
  14. core-ci voted on patch set 24 V +1 11/17/26, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114686

  15. Oli Bartsch voted on patch set 24 CR +1 V +1 11/17/26, 14:10

  16. Simon Schaufelberger voted on patch set 24 CR +1 V +1 11/17/26, 14:22

  17. Simon Schaufelberger commented on patch set 24 CR 0 V 0 11/17/26, 14:25

    FrontendPasswordAuthenticator.php:106

    does it make sense to log the username and IP here as well?
  18. Benni Mack commented on patch set 24 11/17/26, 14:46

    FrontendPasswordAuthenticator.php:106 Reply

    we don't have a username yet at this point. IP is OK I think, we could also set the request token as additional payload.
  19. Benni Mack uploaded patch set 25 CR +1 V +1 11/17/26, 14:48

  20. Benni Mack commented on patch set 25 11/17/26, 14:49

    FrontendPasswordAuthenticator.php:106 Reply

    Done
  21. Simon Schaufelberger commented on patch set 25 CR +1 V +1 11/17/26, 14:50

    FrontendPasswordAuthenticator.php:106 Reply

    Done
  22. Oli Bartsch voted on patch set 25 CR +1 V +1 11/17/26, 14:52

  23. core-ci voted on patch set 25 V +1 11/17/26, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114743

  24. Benni Mack voted on patch set 25 CR +2 V +2 11/17/26, 15:10

  25. Benni Mack merged patch set 26 11/17/26, 15:10