Review 13.4 Merged

95292[BUGFIX] Prevent PHP warning on invalid regex in replacement stdWrap

Georg Ringer CR +2 V +2 Easy +17 −0 updated 08/12/26, 14:00

Commit message

When useRegExp is enabled and "search" is not a compilable pattern
(e.g. a single backslash), preg_replace() emitted a warning and
returned null, silently wiping the content. Validate the pattern up
front and skip such invalid actions, keeping the content untouched.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Georg Ringer commented on patch set 1 08/12/26, 13:31

    Cherry Picked from branch 14.3. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php * typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php
  2. Georg Ringer commented on patch set 1 08/12/26, 13:32

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 08/12/26, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106541

  4. Georg Ringer uploaded patch set 2 V -1 08/12/26, 13:48

  5. core-ci voted on patch set 2 V +1 08/12/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106542

  6. Georg Ringer voted on patch set 2 CR +2 V +2 08/12/26, 14:00

  7. Georg Ringer merged patch set 3 08/12/26, 14:00