95294[BUGFIX] Resolve composer-named TER dependencies in classic mode
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2634
Show 59 earlier messages
-
Anton Danilov uploaded patch set 1 08/12/26, 14:37
-
core-ci voted on patch set 1 V -1 08/12/26, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106551
-
core-ci voted on patch set 1 V +1 08/12/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106551
-
Anton Danilov uploaded patch set 2
V +108/13/26, 19:01Resolving Merge Conflict -
core-ci voted on patch set 2 V +1 08/13/26, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106670
-
Simon Schaufelberger commented on patch set 2 08/15/26, 12:41
@typo3@helhum.io I guess you are the right person to review this one -
Benni Mack commented on patch set 2 08/16/26, 04:46
Could you please add tests (similar to the ones we've seen in the issue)? -
Anton Danilov uploaded patch set 3
V +108/17/26, 11:20Replace mocked Unit test with Functional repository tests -
core-ci voted on patch set 3 V +1 08/17/26, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106822
-
Anton Danilov commented on patch set 3 08/17/26, 11:29
Reply
Done. Added functional ExtensionRepositoryTest cases mirroring the issue's reproducer (record with extension_key + composer_name, both finders resolve by composer name) -
Oliver Klee voted on patch set 3 V +1 08/18/26, 08:01
-
Sebastian Fischer voted on patch set 3 CR +1 08/21/26, 09:26
-
Helmut Hummel commented on patch set 3 08/27/26, 17:07
Couldn't the composer info column be a native json type in the db? and couldn't we then directly query the composer name directly from this column? -
Helmut Hummel commented on patch set 3 CR +1 08/27/26, 17:08
other than that, change looks good, thanks! -
Helmut Hummel commented on patch set 3 08/27/26, 17:08
Reply
Done -
Stefan Bürk commented on patch set 3 CR -1 09/01/26, 12:06
Tmp -1, reviewing/testing .... -
Stefan Bürk commented on patch set 3 09/02/26, 13:35
Should we possibly postpne this until * 94961: [TASK] Store remote extension list as JSON files | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94961 has landed and than adopt for that structure instead of extension the database table here now which the above change make it unused and directly obsolete ? @typo3@helhum.io what do you think ? -
Benni Mack commented on patch set 3 09/02/26, 13:36
Reply
I am still checking if JSON is faster / better tbh -
Anton Danilov uploaded patch set 4
CR +1V +109/09/26, 10:43Resolving Merge Conflict -
core-ci voted on patch set 4 V +1 09/09/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108156
-
Anton Danilov uploaded patch set 5
V +109/09/26, 11:06Resolving Merge Conflict -
core-ci voted on patch set 5 V +1 09/09/26, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108158
-
Anton Danilov rebased onto patch set 6
V +109/09/26, 13:32 -
core-ci voted on patch set 6 V +1 09/09/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108185
-
Benni Mack commented on patch set 6 CR +1 V +1 09/10/26, 06:56
Change is fine from my side. However, we do not consider "replaces" sections, and I know that some extension authors changed their vendor name a couple of times, but this solution is already better than the others. -
Benni Mack commented on patch set 6 09/10/26, 06:56
Reply
Done -
Oliver Klee voted on patch set 6 V +1 09/10/26, 07:19
-
Benni Mack uploaded patch set 7
CR +1V +109/14/26, 10:15 -
Benni Mack voted on patch set 7 CR +1 V +1 09/14/26, 10:15
-
core-ci voted on patch set 7 V +1 09/14/26, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108514
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 09/14/26, 10:26
-
Georg Ringer voted on patch set 7 CR +2 V +2 10/09/26, 19:32
-
Simon Schaufelberger commented on patch set 7 10/09/26, 19:52
Reply
Done -
Georg Ringer merged patch set 8 10/10/26, 05:08