Review main Merged

953[BUGFIX] Pages with Enforce Protocol (SSL) may generate wrong URL

Steffen Ritter CR +2 V +1 Easy +5 −0 updated 06/03/13, 20:49

Commit message

If TYPO3 is installed in a subfolder, you won't need a absRefPrefix set because normally links are relative.
If a Protocol change will (SSL -> PLAIN or vice versa) happen, the URL has to be generated absolute.
This will fail in the described behaviour.

Notes:
This one has been reported by Michael Maier.
Attached patch is my "easier to read" version doing the same as _v2 of Jigal and the result of talking through all cases which may arise.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Tobias Liebig +1
    • Sebastian Fischer +1
    • Helmut Hummel +1
    • Andreas Wolf +1
  • Verified V +1
    • Helmut Hummel +1
    • Andreas Wolf +1

Files 1

Review log 8

  1. Peter Niederlag commented on patch set 1 03/10/11, 08:01

    I would prefer that you didn't submit this please hang on (aka dont press submit), as we want to keep this as an example for a "commit on mutiple branches" test/review..
  2. Andreas Wolf commented on patch set 1 03/10/11, 08:01

    Verified; Looks good to me, but someone else must approve Works as advertised and fixes the bug with wrong links. @Helmut: Could you describe a testcase for what you are worried about? For me it worked with and without config.absRefPrefix set (value was only an absolute path, no domain). @Peter: May we push this now?
  3. Helmut Hummel commented on patch set 1 03/10/11, 08:01

    absRefPrefix must not contain the scheme nor the host. I can be something like "/" or "/subfolder/". These cases should also be handled.
  4. Helmut Hummel commented on patch set 1 03/10/11, 08:01

    Verified; Looks good to me, but someone else must approve Ah, OK. Got it. Everything is fine with the patch.
  5. Tobias Liebig commented on patch set 1 03/10/11, 08:01

    Looks good to me, but someone else must approve
  6. Sebastian Fischer commented on patch set 1 03/10/11, 08:01

    Looks good to me, but someone else must approve by reading
  7. Jigal van Hemert commented on patch set 1 03/10/11, 08:01

    Looks good to me, approved It has enough votes from other by testing. Steffen and I discussed this version earlier on skype, so we should get this in core. Will try to push to 4.5 tonight.
  8. Jigal van Hemert merged patch set 1 03/10/11, 08:01