953[BUGFIX] Pages with Enforce Protocol (SSL) may generate wrong URL
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Tobias Liebig +1
- Sebastian Fischer +1
- Helmut Hummel +1
- Andreas Wolf +1
-
Verified V +1
- Helmut Hummel +1
- Andreas Wolf +1
Files 1
Review log 8
-
Peter Niederlag commented on patch set 1 03/10/11, 08:01
I would prefer that you didn't submit this please hang on (aka dont press submit), as we want to keep this as an example for a "commit on mutiple branches" test/review.. -
Andreas Wolf commented on patch set 1 03/10/11, 08:01
Verified; Looks good to me, but someone else must approve Works as advertised and fixes the bug with wrong links. @Helmut: Could you describe a testcase for what you are worried about? For me it worked with and without config.absRefPrefix set (value was only an absolute path, no domain). @Peter: May we push this now? -
Helmut Hummel commented on patch set 1 03/10/11, 08:01
absRefPrefix must not contain the scheme nor the host. I can be something like "/" or "/subfolder/". These cases should also be handled. -
Helmut Hummel commented on patch set 1 03/10/11, 08:01
Verified; Looks good to me, but someone else must approve Ah, OK. Got it. Everything is fine with the patch. -
Tobias Liebig commented on patch set 1 03/10/11, 08:01
Looks good to me, but someone else must approve -
Sebastian Fischer commented on patch set 1 03/10/11, 08:01
Looks good to me, but someone else must approve by reading -
Jigal van Hemert commented on patch set 1 03/10/11, 08:01
Looks good to me, approved It has enough votes from other by testing. Steffen and I discussed this version earlier on skype, so we should get this in core. Will try to push to 4.5 tonight. -
Jigal van Hemert merged patch set 1 03/10/11, 08:01