Review main Merged

95304[TASK] Add array return type to FormDataGroupInterface::compile

Wouter Wolters CR +2 V +2 Easy +2 −23 updated 09/01/26, 10:13

Commit message

Resolve the TODO by adding the correct return type.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Wouter Wolters uploaded patch set 1 08/12/26, 19:51

  2. core-ci voted on patch set 1 V +1 08/12/26, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106571

  3. Oliver Klee voted on patch set 1 CR +1 08/12/26, 19:59

  4. Oliver Klee voted on patch set 1 V +1 08/12/26, 19:59

  5. Georg Ringer voted on patch set 1 CR +1 V +1 08/12/26, 20:40

  6. Benni Mack voted on patch set 1 CR +2 V +2 08/31/26, 21:38

  7. Benni Mack merged patch set 2 08/31/26, 21:38

  8. Garvin Hicking commented on patch set 2 09/01/26, 10:13

    Added this followup to document the BC: 95515: [!!!][DOCS] Add array return type to FormDataGroupInterface::compile | https://review.typo3.org/c/Packages/TYPO3.CMS/+/95515