95306[TASK] Declare FormDefinition final
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+1 −2
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php+3 −1
- typo3/sysext/form/Tests/Functional/Domain/Finishers/SaveToDatabaseFinisherTest.php+1 −3
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+29 −18
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+15 −14
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+2 −8
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+21 −11
- typo3/sysext/form/Tests/Unit/Domain/FormElements/FileUploadTest.php+5 −25
Review log 1215
-
Wouter Wolters uploaded patch set 1 08/12/26, 20:00
-
core-ci voted on patch set 1 V -1 08/12/26, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106573
-
Wouter Wolters uploaded patch set 2
V -108/12/26, 20:22 -
core-ci voted on patch set 2 V +1 08/12/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106576
-
Oliver Klee voted on patch set 2 CR +1 V +1 08/13/26, 07:11
-
Simon Schaufelberger commented on patch set 2 CR -1 V -1 08/15/26, 12:49
Needs a rebase. I failed to resolve the conflict myself. -
Wouter Wolters uploaded patch set 3
CR +1V +109/01/26, 19:52 -
core-ci voted on patch set 3 V +1 09/01/26, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107520
-
Georg Ringer voted on patch set 3 CR +1 V +1 09/01/26, 20:14
-
Oliver Klee voted on patch set 3 V +1 09/01/26, 20:27
-
Oliver Klee voted on patch set 3 CR +1 09/01/26, 20:28
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/03/26, 08:34
-
Simon Schaufelberger commented on patch set 3 09/03/26, 08:35
Reply
Done -
Benni Mack voted on patch set 3 CR +2 V +2 09/03/26, 08:40
-
Benni Mack merged patch set 4 09/03/26, 08:40