Review main Merged

95306[TASK] Declare FormDefinition final

Wouter Wolters CR +2 V +2 Normal +77 −82 updated 09/03/26, 08:40

Commit message

FormDefinition is internal and explicitly not intended to be
subclassed. Declare the class final and replace its test doubles
with real lightweight instances.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1215

  1. Wouter Wolters uploaded patch set 1 08/12/26, 20:00

  2. core-ci voted on patch set 1 V -1 08/12/26, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106573

  3. Wouter Wolters uploaded patch set 2 V -1 08/12/26, 20:22

  4. core-ci voted on patch set 2 V +1 08/12/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106576

  5. Oliver Klee voted on patch set 2 CR +1 V +1 08/13/26, 07:11

  6. Simon Schaufelberger commented on patch set 2 CR -1 V -1 08/15/26, 12:49

    Needs a rebase. I failed to resolve the conflict myself.
  7. Wouter Wolters uploaded patch set 3 CR +1 V +1 09/01/26, 19:52

  8. core-ci voted on patch set 3 V +1 09/01/26, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107520

  9. Georg Ringer voted on patch set 3 CR +1 V +1 09/01/26, 20:14

  10. Oliver Klee voted on patch set 3 V +1 09/01/26, 20:27

  11. Oliver Klee voted on patch set 3 CR +1 09/01/26, 20:28

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/03/26, 08:34

  13. Simon Schaufelberger commented on patch set 3 09/03/26, 08:35

    Reply

    Done
  14. Benni Mack voted on patch set 3 CR +2 V +2 09/03/26, 08:40

  15. Benni Mack merged patch set 4 09/03/26, 08:40