Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Stale

95308[TASK] Deprecate QueryBuilder::castFieldToTextType()

Wouter Wolters CR -2 V +1 Normal +71 −5 updated 08/13/26, 10:10

Commit message

Deprecate castFieldToTextType() in favor of
ExpressionBuilder::castText() and migrate all remaining Core usages
to the replacement API.

Add extension scanner coverage and document the migration.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/08/95308/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/08/95308/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Stefan Bürk -2
    • Oliver Klee +1
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Wouter Wolters uploaded patch set 1 08/12/26, 20:19

  2. core-ci voted on patch set 1 V +1 08/12/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106575

  3. Oliver Klee voted on patch set 1 CR +1 V +1 08/12/26, 20:28

  4. Stefan Bürk commented on patch set 1 CR -2 08/13/26, 10:10

    Unresolved

    Thank you @typo3@wouterwolters.nl, but I need to look deeper on that. ExpressionBuilder::castText() is a complete other implementation and doing things slightly different and is not a simple drop-in replacement. If I remember right there was a reason back then not to replace it, just can't remember what it was. So I put a -2 on that (temporarly) to avoid a to early merge without having that checked.