Review main Ready for review Quiet

95309[TASK] Remove obsolete inline structure compiler input

Wouter Wolters CR +1 V +1 Normal +50 −4 updated 10/08/26, 08:10

Commit message

Both localization controllers compile the parent to obtain its field
configuration, language and current related UID list. Resolving this
data does not require inlineStructure.

The stack is used when compiling children, which these parent calls
explicitly disable via inlineCompileExistingChildren. The parent is
not rendered, so the compiler's default empty structure is sufficient.

Newly localized children are compiled separately and still receive
the original inlineStructure explicitly.

Add functional coverage for both controller flows.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/95309/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/95309/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Oliver Klee +1
    • Josua Vogel +1
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • core-ci +1 CI

Merge conflicts 4

Issues 1

Files 3

Review log 1619

  1. Wouter Wolters uploaded patch set 1 08/12/26, 20:34

  2. core-ci voted on patch set 1 V +1 08/12/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106577

  3. Oliver Klee voted on patch set 1 V +1 08/13/26, 07:11

  4. Oliver Klee voted on patch set 1 CR +1 08/13/26, 07:11

  5. Georg Ringer voted on patch set 1 CR +1 V +1 08/13/26, 07:21

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/13/26, 09:40

  7. Stefan Bürk commented on patch set 1 08/13/26, 19:06

    FormInlineAjaxControllerTest.php:49

    Do we really need this for all tests ? or only the two new tests ? (or one of it) - thatn this should be moved I guess.
  8. Wouter Wolters uploaded patch set 2 CR +1 V +1 08/14/26, 17:39

  9. Wouter Wolters commented on patch set 1 08/14/26, 17:40

    FormInlineAjaxControllerTest.php:49 Reply

    Done
  10. core-ci voted on patch set 2 V +1 08/14/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106708

  11. Georg Ringer voted on patch set 2 CR +1 V +1 09/07/26, 19:40

  12. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/02/26, 23:06

  13. Oliver Klee voted on patch set 2 CR +1 V +1 10/05/26, 09:30

  14. Oli Bartsch commented on patch set 2 10/05/26, 15:08

    Could you please elaborate why it is unnecessary here?
  15. Wouter Wolters updated the commit message in patch set 3 CR +1 V +1 10/05/26, 16:46

  16. Wouter Wolters commented on patch set 3 10/05/26, 16:46

    Reply

    Done
  17. Oliver Klee voted on patch set 3 CR +1 V +1 10/05/26, 16:48

  18. core-ci voted on patch set 3 V +1 10/05/26, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110131

  19. Josua Vogel voted on patch set 3 CR +1 10/08/26, 08:10