Review main Merged

95318[BUGFIX] Handle backed enum record types in f:render.text

Chris Müller CR +2 V +2 Easy +39 −3 updated 10/19/26, 08:16

Commit message

Extbase models can represent their TCA record type with a backed enum.
Returning this enum from getRecordType() causes a TypeError because the
method requires a nullable string.

Use the enum's backing value as a string when selecting the TCA schema.
Add a functional regression test for a CType field holding a backed enum.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Matthias Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1216

  1. Chris Müller uploaded patch set 1 08/13/26, 15:31

  2. Chris Müller marked it work in progress 08/13/26, 15:31

  3. Chris Müller commented on patch set 1 08/13/26, 15:35

    This change is ready for review.
    Have to add test xases, will deal with it after returning from holiday in September.
  4. Chris Müller marked it work in progress 08/13/26, 15:35

  5. Chris Müller updated the commit message in patch set 2 08/13/26, 15:36

  6. Chris Müller updated the commit message in patch set 3 08/13/26, 15:36

  7. core-ci voted on patch set 1 V +1 08/13/26, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106659

  8. core-ci voted on patch set 2 V +1 08/13/26, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106660

  9. core-ci voted on patch set 3 V +1 08/13/26, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106661

  10. Matthias Vogel commented on patch set 3 09/10/26, 10:44

    TextViewHelper.php:185

    I like the idea. I think we should take a look at how Extbase handles enums and how they are converted to the database. We should then use that same approach here.
  11. Matthias Vogel uploaded patch set 4 V +1 10/17/26, 13:28

  12. Matthias Vogel commented on patch set 4 CR +1 V +1 10/17/26, 13:29

    Reply

    Done

    TextViewHelper.php:185 Reply

    Done
  13. core-ci voted on patch set 4 V +1 10/17/26, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111460

  14. Chris Müller marked it ready for review 10/19/26, 07:14

  15. Garvin Hicking voted on patch set 4 CR +2 V +2 10/19/26, 07:55

  16. Garvin Hicking merged patch set 5 10/19/26, 08:16