Review main Merged

95319[TASK] Deprecate retrieval of schedulable commands

Wouter Wolters CR +2 V +2 Normal +70 −1 updated 09/01/26, 21:15

Commit message

Deprecate CommandRegistry->getSchedulableCommands() in favor of
getSchedulableCommandsConfiguration(). Keep coverage for the deprecated
method and add coverage for the replacement API.

Add extension scanner coverage and document the migration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Wouter Wolters uploaded patch set 1 08/13/26, 15:48

  2. core-ci voted on patch set 1 V +1 08/13/26, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106662

  3. Stefan Bürk commented on patch set 1 08/13/26, 18:36

    AsCommandAttributeTest.php:99

    As long as the deprecated method is not dropped we should keep that test case/method (duplicate) with: * `expectUserDeprecationMessage()`/`expectUserDeprecationMessageMatches` * OR php attribute `#[IgnoreDeprecations]` on the test (not the full testcase) testing the deprecated method.
  4. Wouter Wolters uploaded patch set 2 V +1 09/01/26, 19:40

  5. Wouter Wolters commented on patch set 2 09/01/26, 19:41

    AsCommandAttributeTest.php:99 Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/01/26, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107514

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 09/01/26, 20:38

  8. Benni Mack voted on patch set 2 CR +2 V +2 09/01/26, 21:15

  9. Benni Mack merged patch set 3 09/01/26, 21:15