Review main Merged

95321[TASK] Deprecate unused action menu group argument

Wouter Wolters CR +2 V +2 Normal +50 −3 updated 09/02/26, 16:00

Commit message

Deprecate the unused defaultController argument of the
<f:be.menus.actionMenuItemGroup> ViewHelper. Passing the argument now
triggers a deprecation notice and will no longer be supported in
TYPO3 v16.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Praetorius +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Wouter Wolters uploaded patch set 1 08/13/26, 17:02

  2. core-ci voted on patch set 1 V +1 08/13/26, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106665

  3. Georg Ringer voted on patch set 1 CR +1 09/01/26, 20:15

  4. Benni Mack voted on patch set 1 CR +1 V +1 09/01/26, 20:40

  5. Simon Praetorius commented on patch set 1 09/01/26, 20:57

    ActionMenuItemGroupViewHelper.php:57

    Deprecating an argument like this works fine, but there's an even better way: If you implement the `ViewHelperNodeInitializedEventInterface`, you can hook early into the parser, which allows detecting deprecations with `vendor/bin/typo3 fluid:analyze`. For example, we did this in v14 in `<f:asset.script>` with the `useNonce` parameter.
  6. Georg Ringer uploaded patch set 2 CR +1 V +1 09/01/26, 21:15

  7. core-ci voted on patch set 2 V -1 09/01/26, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107535

  8. Georg Ringer uploaded patch set 3 09/01/26, 21:50

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  9. core-ci voted on patch set 3 V -1 09/01/26, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107540

  10. Wouter Wolters uploaded patch set 4 V -1 09/02/26, 15:49

  11. Wouter Wolters commented on patch set 4 09/02/26, 15:49

    ActionMenuItemGroupViewHelper.php:57 Reply

    Done
  12. Simon Praetorius voted on patch set 4 CR +1 V +1 09/02/26, 15:53

  13. core-ci voted on patch set 4 V +1 09/02/26, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107648

  14. Benni Mack commented on patch set 4 CR +2 V +2 09/02/26, 16:00

    thank you!
  15. Benni Mack merged patch set 5 09/02/26, 16:00