Review main Merged

95327[TASK] Raise phpunit/phpunit to ^13.3.0

Stefan Bürk CR +2 V +2 Easy +5 −4 updated 08/14/26, 06:26

Commit message

The upgrade to PHPUnit 13 replaced the deprecated "cacheResult"
attribute of the PHPUnit configuration files with its successor
"recordTestRunHistory". That rename is the one intended by upstream,
but the attribute has only been added with PHPUnit 13.3.0 - in the
very same release which deprecated "cacheResult".

The development dependency however still allowed 13.2.6, which made
"composerInstallMin" resolve a PHPUnit not knowing the attribute.
Such a run emits a configuration validation warning and exits
non-zero, which failed all "min" jobs of the main nightly pipeline
although no test failed at all.

The dependency is raised to ^13.3.0 accordingly. Nothing moves in the
lock file, which already holds 13.3.0.

Both configuration files additionally referenced the 13.2 schema and
now point to 13.3. PHPUnit does not read that reference, it validates
against the schema of the installed version, but IDEs do and flagged
the attribute as invalid.

The cache directory "Build/phpunit/.phpunit.cache" is added to
".gitignore". It is created for any configured "cacheDirectory" and
receives files as soon as a PHPUnit not knowing the attribute runs,
since recording falls back to being enabled then.

Used command(s):

    Build/Scripts/runTests.sh -s composer -- \
        req --dev phpunit/phpunit ^13.3.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 34

  1. Stefan Bürk uploaded patch set 1 08/14/26, 06:12

  2. core-ci voted on patch set 1 V +1 08/14/26, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106690

  3. Stefan Bürk commented on patch set 1 CR +2 V +2 08/14/26, 06:26

    Merging without votes, reasoning: * dev dependency only raise to ensure lowest version of phpunit for options used * Ensures valid config phpunit configuration. * Makes nightly main happy again.
  4. Stefan Bürk merged patch set 2 08/14/26, 06:26