Review 14.3 Merged

95331[BUGFIX] Apply intTarget and extTarget to page links

Stefan Bürk CR +2 V +2 Normal +49 −2 updated 08/14/26, 14:19

Commit message

Since #106405, resolveTargetAttribute() accepts the content object
renderer as a third argument and reads config.intTarget and
config.extTarget from its request. PageLinkBuilder did not pass it,
so the frontend TypoScript configuration collapsed to an empty
array and page links were rendered without a target attribute. The
per-link `target.` and `extTarget.` stdWrap was skipped for the same
reason.

Pass the already available renderer at both call sites, matching
the other typolink builders, and cover the intTarget, extTarget and
stdWrap cases with a regression test.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Stefan Bürk commented on patch set 1 08/14/26, 13:51

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 08/14/26, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106705

  3. core-ci voted on patch set 1 V +1 08/14/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106705

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 08/14/26, 14:19

  5. Stefan Bürk merged patch set 2 08/14/26, 14:19