Review 14.3 Merged

95336[TASK] Stabilize flaky inline_1n e2e tests

Stefan Bürk CR +2 V +2 Normal +180 −51 updated 08/14/26, 20:37

Commit message

The playwright test "inline_1n sorts an inline child down" failed
sporadically with a click running into the 30 seconds test timeout,
while a retry of the whole CI job passed and turned the pipeline green
again.

The spec runs as a serial group, and such a group is retried as a whole
against the database the previous attempt left behind. The styleguide
fixture data is therefore pristine for the first attempt only, while
the spec pinned itself to exactly that data: the child with uid 1, its
title, and absolute positions within the relation. Every attempt also
added another child, so the positional selectors started to address
something else than they mean. The sorting test then picked the "move
down" control of the last child, which FormEngine renders invisible,
and the click could never succeed. It surfaced as a test timeout only,
without stating what was actually wrong.

The spec now builds its own baseline instead of relying on the fixture
data. Once per attempt, all children of the relation are removed and
two children with known titles are created, and the panel expand state
is normalised as well, since it is stored in the backend user
configuration and survives a reload. Within an attempt the tests keep
building on each other as before, but every attempt starts from the
same state.

Nothing addresses records by uid anymore. Children are picked by the
field name read from the form, a newly created one through the "NEW"
identifier it carries until it is saved. Their titles are taken from
the panel header, since a collapsed child is rendered without its
fields and loads them only when it gets expanded. The sorting test
verifies a relative move of one position and re-reads the record
afterwards to verify the sorting has been persisted. The record list of
the page is no longer used for that, since it holds the children of all
parent records and can not tell the order within a single relation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Stefan Bürk uploaded patch set 1 08/14/26, 20:11

  2. core-ci voted on patch set 1 V +1 08/14/26, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106716

  3. core-ci commented on patch set 1 08/14/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106718

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 08/14/26, 20:37

  5. Stefan Bürk merged patch set 2 08/14/26, 20:37