95342[!!!][TASK] Remove PKG file system path resolving
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/95342/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/95342/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Oliver Klee +1
- Wouter Wolters +1
- Helmut Hummel -1
-
Verified V +1 Needs a vote
- Oliver Klee +1
- Wouter Wolters +1
- core-ci +1 CI
Relation chain 2
-
95342 [!!!][TASK] Remove PKG file system path resolving This change
-
main
95333[BUGFIX] Handle backend logo as system resource
The chain has patch set 2 of 9, the changes above it need a rebase.
Merge conflicts 1
Issues 2
Files 3
Review log 78
-
Stefan Bürk uploaded patch set 1 08/15/26, 16:23
-
core-ci voted on patch set 1 V +1 08/15/26, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106765
-
Wouter Wolters voted on patch set 1 CR +1 V +1 08/15/26, 18:25
-
Georg Ringer commented on patch set 1 08/17/26, 08:44
would like to see a review of helmut hereExtensionManagementUtility.php:81Unresolvedthe exception msg should also provides a solution -
Oliver Klee voted on patch set 1 CR +1 V +1 08/18/26, 08:01
-
Helmut Hummel commented on patch set 1 CR -1 08/20/26, 08:04
Looking into it. Please do not merge for now. -
Helmut Hummel commented on patch set 1 08/20/26, 08:36
There were reasons, this was introduced. One of them is, that the resource API misses some things, e.g. handling with collections (directories). The goal is to have an API that covers all cases, where previously obtaining the absolute file system path was required. Only then we can remove the possibility to obtain the absolute path, otherwise we limit ourselves the usage of package identifiers in all places. My recommendation therefore is to postpone this deprecation removal until the system resource API and its usage is extendend throughout the core.ExtensionManagementUtility.php:80Unresolvedfrom my point of view, rather than shifting the code around here, the changes done in https://review.typo3.org/c/Packages/TYPO3.CMS/+/91464 to make this happen should be reverted, making this here a onelinerer again: `return static::$packageManager->resolvePackagePath($path);` usages of this method should be changed back as well then. basically a revert of https://review.typo3.org/c/Packages/TYPO3.CMS/+/91464, but leaving the driveby fixes in. -
Helmut Hummel commented on patch set 1 08/23/26, 10:12
Reply Unresolved
If we really want to support PKG:// syntax everywhere, then we need to get rid of ALL places using GeneralUtility::getFileAbsFileName and using system resource API there (including extending the API so that it will work for all use cases). Until then, every place, that triggers the deprecation is only supporting EXT: syntax until this place is fixed. We can discuss though, whether an exception is preferred to FORCE users to use the older syntax, or whether a deprecation is enough (I obviously vote for the latter)