Review main Merged

95347[TASK] Skip database setup for database-free functional tests

Wouter Wolters CR +2 V +2 Easy +48 −0 updated 09/08/26, 10:22

Commit message

Mark 24 functional test classes as not requiring database setup.

These tests need the TYPO3 functional bootstrap, dependency injection,
extension loading, configuration, or filesystem setup, but they do not
read or write persistent data.

FunctionalTestCase initializes a complete database schema for the first
test and resets it before every subsequent test by default. Skipping
that work avoids unnecessary schema creation, truncation, and sequence
resets while preserving the rest of the functional test environment.

The change covers 579 tests and passes with 1,107 assertions on SQLite,
PostgreSQL, and MariaDB. PostgreSQL and SQLite were also verified with
randomized execution.

LocalizationUtilityTest improves from a median of 11.782 seconds to
2.392 seconds. FlexFormToolsTest improves from 3.570 seconds to
2.525 seconds on SQLite.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 2836

Show 811 earlier messages
  1. Wouter Wolters uploaded patch set 1 08/16/26, 21:48

  2. core-ci voted on patch set 1 V +1 08/16/26, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106788

  3. Wouter Wolters uploaded patch set 2 V +1 08/17/26, 10:31

  4. core-ci voted on patch set 2 V +1 08/17/26, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106819

  5. Wouter Wolters updated the commit message in patch set 3 V +1 09/04/26, 14:19

  6. Wouter Wolters marked it ready for review 09/04/26, 14:19

  7. core-ci voted on patch set 3 V +1 09/04/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107888

  8. Oliver Klee voted on patch set 3 CR +1 V +1 09/04/26, 14:31

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/04/26, 14:39

  10. Simon Schaufelberger commented on patch set 3 09/04/26, 14:41

    How did you find these tests that don't need a DB?
  11. Wouter Wolters commented on patch set 3 09/07/26, 09:13

    Reply

    With the help of an AI agent.
  1. Georg Ringer commented on patch set 3 CR +1 V +1 09/07/26, 18:26

    shouldn't we also backport that to 14.3?
  2. Wouter Wolters commented on patch set 3 09/07/26, 18:31

    Reply

    IMO up to a core merger to decide. I think it can help as it improves the speed of the test suite.
  3. Simon Schaufelberger commented on patch set 3 09/07/26, 18:38

    Reply

    I would totally agree, as this is a trivial change and will improve CI a lot
  4. Simon Schaufelberger updated the commit message in patch set 4 CR +1 V +1 09/07/26, 18:39

  5. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/07/26, 18:39

  6. Simon Schaufelberger updated the commit message in patch set 5 CR +1 V +1 09/07/26, 18:39

  7. Simon Schaufelberger voted on patch set 5 CR +1 V +1 09/07/26, 18:39

  8. core-ci voted on patch set 5 V +1 09/07/26, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108024

  9. Oliver Klee voted on patch set 5 CR +1 V +1 09/07/26, 18:51

  10. Georg Ringer updated the commit message in patch set 6 CR +1 V +1 09/07/26, 19:16

  11. core-ci voted on patch set 6 V +1 09/07/26, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108029

  12. Oliver Klee voted on patch set 6 CR +1 V +1 09/07/26, 19:29

  13. Simon Schaufelberger commented on patch set 6 09/07/26, 19:38

    why not backport this to 13 as well? @georg.ringer@gmail.com
  14. Wouter Wolters uploaded patch set 7 CR +1 V +1 09/07/26, 19:49

  15. Wouter Wolters updated the commit message in patch set 8 09/07/26, 19:52

  16. core-ci voted on patch set 7 V +1 09/07/26, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108032

  17. core-ci voted on patch set 8 V +1 09/07/26, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108034

  18. Oliver Klee voted on patch set 8 CR +1 V +1 09/07/26, 20:08

  19. Simon Schaufelberger updated the commit message in patch set 9 CR +1 V +1 09/07/26, 21:14

  20. Simon Schaufelberger commented on patch set 9 CR +1 V +1 09/07/26, 21:14

    Reply

    Done
  21. core-ci voted on patch set 9 V +1 09/07/26, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108040

  22. Oliver Klee voted on patch set 9 CR +1 V +1 09/07/26, 21:24

  23. Garvin Hicking voted on patch set 9 CR +1 V +1 09/08/26, 08:55

  24. Georg Ringer voted on patch set 9 CR +2 V +2 09/08/26, 10:22

  25. Georg Ringer merged patch set 10 09/08/26, 10:22