Review 14.3 Merged

95348[TASK] Test QueryResult with objects instead of arrays

Oliver Klee CR +2 V +2 Easy +14 −12 updated 08/17/26, 10:45

Commit message

`QueryResult` iterates over objects, not over arrays.
Adapt the unit tests to use the correct types.

This was detected while adding native type declarations
to `QueryResult`.

Also tighten some assertions in the test.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Oliver Klee commented on patch set 1 08/17/26, 10:11

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php
  2. core-ci voted on patch set 1 V -1 08/17/26, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106814

  3. Oliver Klee uploaded patch set 2 V -1 08/17/26, 10:20

  4. Oliver Klee uploaded patch set 3 08/17/26, 10:21

  5. core-ci voted on patch set 2 V +1 08/17/26, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106815

  6. core-ci voted on patch set 3 V +1 08/17/26, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106816

  7. Oliver Klee marked it ready for review 08/17/26, 10:42

  8. Georg Ringer voted on patch set 3 CR +2 V +2 08/17/26, 10:43

  9. Georg Ringer merged patch set 4 08/17/26, 10:45